Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MEF importing constructors - Possibly not ok #4856

Open
6 of 9 tasks
bigfluffycookie opened this issue Sep 7, 2023 · 0 comments
Open
6 of 9 tasks

Fix MEF importing constructors - Possibly not ok #4856

bigfluffycookie opened this issue Sep 7, 2023 · 0 comments
Labels
Infrastructure Project structure, build and release pipeline etc Threading Relates to thread handling - be careful! Type: Task

Comments

@bigfluffycookie
Copy link
Contributor

bigfluffycookie commented Sep 7, 2023

Sub Group of Ticket #4512

  • LocalHotspotsStore: calls InitializeServerHotspots(this.serverHotspotStore.GetAll()); What does this do?
  • CssEslintBridgeClient: calls eslintBridgeProcessFactory.Create() and creates several other objects. ditto JavaScriptEslintBridgeClient and TypeScriptEslintBridgeClient
  • SonarErrorListDataSource: calls var errorTableManager = tableManagerProvider.GetTableManager(StandardTables.ErrorsTable);. Check what the VS Extensibility sample in GitHub does - it might be ok.
  • SecretsAnalyzer: calls ruleSettingsProvider = ruleSettingsProviderFactory.Get(Language.Secrets)
  • ImportBeforeInstallTrigger: calls TriggerUpdateAsync().Forget(); // easy to fix - directly create by a package -> make the package call it
  • SSESessionManager: calls CreateSessionIfInConnectedMode(activeSolutionBoundTracker.CurrentConfiguration); // does this switch threads?
  • SonarQubeNavigationItem: makes calls to fetch resources. Needs a bit more investigation.
  • TypeScript.Analyzer.AnalyzerBase: calls rulesProviderFactory and eslintBridgeAnalyzerFactory. What do these do, and could they be deferred?
  • NodeLocationsProvider: creates various INodeLocationProvider instances - need to check them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Project structure, build and release pipeline etc Threading Relates to thread handling - be careful! Type: Task
Projects
None yet
Development

No branches or pull requests

2 participants