Make SSESessionManager ctor free threaded #4863
Conversation
| } | ||
|
|
||
| [Export(typeof(ISSESessionManager))] | ||
| [Export(typeof(SSESessionManager))] |
There was a problem hiding this comment.
We dont use this anywhere else so I removed the interface so it is the same as the TriggerImportInstall class
| /// event from the ActiveSolutionBoundTracker) | ||
| /// See https://github.com/SonarSource/sonarlint-visualstudio/issues/3886 | ||
| /// </summary> | ||
| private void LoadServicesAndDoInitialUpdates(IComponentModel componentModel) |
There was a problem hiding this comment.
With how many there are now I thought it made sense to put it in a seperate method.
There was a problem hiding this comment.
The doc comment on the method needs to updated.
| @@ -64,7 +64,7 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke | |||
|
|
|||
| logger.WriteLine(Resources.Package_Initializing); | |||
|
|
|||
| sseSessionManager = componentModel.GetService<ISSESessionManager>(); | |||
| LoadServicesAndDoInitialUpdates(componentModel); | |||
There was a problem hiding this comment.
I moved it up as on line 85 there is an await and this way it doesnt disturb the load order as much
|
A little confused about the dispose code smell as I didnt change anything on that, should I fix it? |
| /// <summary> | ||
| /// Reacts to project changes and opens/closes Server Sent Events sessions | ||
| /// </summary> | ||
| internal interface ISSESessionManager : IDisposable |
There was a problem hiding this comment.
I think you need to make SSESessionManager : IDisposable now (one of the code smells).
|
SonarCloud Quality Gate failed.
|
* Make SSESessionManager ctor free threaded * pr fixes
* Make SSESessionManager ctor free threaded * pr fixes
part of #4856