Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Now Playing View #155

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vixalien
Copy link
Contributor

So that it looks a bit more like the mockups at https://gitlab.gnome.org/Teams/Design/other-app-mockups/-/blob/master/plattenalbum/layout.png?ref_type=heads.

Note that the queue has been moved to a new page, and can be accessed by clicking the button in the top.

@vixalien
Copy link
Contributor Author

vixalien commented Oct 30, 2024

Before:

image

After:

image

Note that it's not yet 1:1 conformant to the mockups, but we are getting there.

@SoongNoonien
Copy link
Owner

Note that it's not yet 1:1 conformant to the mockups, but we are getting there.

I'm not sure if this should be a goal. In #132 we discussed the new layout and I pointed out that I'm not a fan of this approach with an extra playlist view for several reasons.

Besides in the current state of this PR it is very hard and unintuitive to get to the playlist when the player is collapsed. And there is no shortcut for that either.

@vixalien
Copy link
Contributor Author

In #132 we discussed the new layout and I pointed out that I'm not a fan of this approach with an extra playlist view for several reasons.

Ohhhh, I'm sorry I didn't see this issue previously. I understand your concerns.

Besides in the current state of this PR it is very hard and unintuitive to get to the playlist when the player is collapsed. And there is no shortcut for that either.

Those can be fixed later, after we figure out the design decisions.

@vixalien
Copy link
Contributor Author

I have a suggestion though: Would it be useful to use an Adw.ToggleGroup to quickly switch from the now playing view to the queue and lyrics.

This is how I'm currently doing it in Muzika:

Now playing Queue Lyrics Related
image image image image

But in Muzika on desktop I use a bottom bar, like this, so it's a bit different.

image

@SoongNoonien
Copy link
Owner

I think this is too complex. What is the issue with having the queue always visible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants