Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SortableJS#1866 #2164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix SortableJS#1866 #2164

wants to merge 5 commits into from

Commits on May 30, 2022

  1. Fix SortableJS#1866 

    Swap plugin now cancels the swap when dragging an element over invalid drop targets.
    @kishtra
    kishtra authored May 30, 2022
    Configuration menu
    Copy the full SHA
    92c88d1 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. rename lastSwapValidEl -> swapValidEl

    @kishtra
    kishtra authored May 31, 2022
    Configuration menu
    Copy the full SHA
    a245450 View commit details
    Browse the repository at this point in the history

  2. Add accidentally removed swapValidEl check

    @kishtra
    kishtra authored May 31, 2022
    Configuration menu
    Copy the full SHA
    6663852 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Remove canceling of _onDrop event

    @kishtra
    kishtra authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    89f4319 View commit details
    Browse the repository at this point in the history

  2. Remove unused drop parameter 

    Also, moved swapValidEl check at the beginning of drop event
    @kishtra
    kishtra authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    379459c View commit details
    Browse the repository at this point in the history