use fallbackParent option instead of fallbackOnBody
#2245
+2,296
−2,562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spassvogel
changed the title
getFallbackParent option instead of fallbackOnBodyfallbackParent option instead of fallbackOnBody
lofcz
added a commit
to lofcz/Sortable
that referenced
this pull request
Jan 31, 2024
|
More flexibility and Controllable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new option parameter
fallbackParent. It allows you to be more flexible with determining where the fallback ghost element gets appended. You can either pass a DOM node or a function that retrieves the dom node.Right now you can choose
fallbackOnBodyand it will use the body, but with this change you have a lot more power in determining what the parent needs to be of the fallback ghost. It's not always feasible to append things to the body.The
fallbackOnBodyis still supported, but marked as obsolete and removed from the docs.