feat: add wasm tx generator for snap sign #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a WASM transaction parser and encoder to the snap. The returned bytes of the `signTransaction` method will be a borsh serialized transaction, that can be directly sent to sequencers. It adds the bytecode of the wasm to the hardcoded snap source so its source is committed to the hash of the published snap. It is done that way to avoid exploits from the UI that might return malicious WASM files and sign tampered messages for the user - having the bytes of the WASM committed to the plugin asserts the signature will be only for the intended message.
bkolad
approved these changes
Nov 15, 2023
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a WASM transaction parser and encoder to the snap. The returned bytes of the
signTransactionmethod will be a borsh serialized transaction, that can be directly sent to sequencers.It adds the bytecode of the wasm to the hardcoded snap source so its source is committed to the hash of the published snap. It is done that way to avoid exploits from the UI that might return malicious WASM files and sign tampered messages for the user - having the bytes of the WASM committed to the plugin asserts the signature will be only for the intended message.