Toss out CAs processed without SIDs #89
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pairs with SpecterOps/SharpHoundCommon#108
When no SID is resolved for a CA we don't want to process the edge or node. Currently SharpHoundCommon has a hostname fallback, where if a SID cannot be resolved a hostname is returned instead, and so for CAs that can't be found in LDAP we still process them as "no name" domain objects if they exist in the DNS. We want instead to throw these nodes/edges out if they can't be queried by LDAP.
Motivation and Context
https://specterops.atlassian.net/browse/BED-4206
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: