Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toss out CAs processed without SIDs #89

Closed
wants to merge 1 commit into from

Conversation

definitelynotagoblin
Copy link
Contributor

Description

Pairs with SpecterOps/SharpHoundCommon#108
When no SID is resolved for a CA we don't want to process the edge or node. Currently SharpHoundCommon has a hostname fallback, where if a SID cannot be resolved a hostname is returned instead, and so for CAs that can't be found in LDAP we still process them as "no name" domain objects if they exist in the DNS. We want instead to throw these nodes/edges out if they can't be queried by LDAP.

Motivation and Context

https://specterops.atlassian.net/browse/BED-4206

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant