Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC reg keys and reorganizing properties in ADCS object's output #78

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Oct 5, 2023

Description

Added the two DC registry keys to the computers output and moved Certificate and CertThumbprint properties into the Properties object in the output for AIACA, RootCA, EnterpriseCA, and NTAuthStore.

How Has This Been Tested?

In my lab.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@JonasBK JonasBK force-pushed the dc-reg-keys-and-adcs-refactor branch from eb1012b to ad2c44f Compare October 5, 2023 14:09
@JonasBK JonasBK merged commit 23a541b into adcs Oct 5, 2023
3 checks passed
@JonasBK JonasBK deleted the dc-reg-keys-and-adcs-refactor branch October 5, 2023 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant