Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: msPKI-RA-Application-Policies parsing #88

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Dec 11, 2023

The msPKI-RA-Application-Policies attribute has two different syntaxes. This change implements parsing of the second syntax described here: https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-crtd/c55ec697-be3f-4117-8316-8895e4399237

The result is that we no longer get strings like this (if syntax 2) in our output:

"applicationpolicies": [
      "msPKI-Asymmetric-Algorithm`PZPWSTR`RSA`msPKI-Hash-Algorithm`PZPWSTR`SHA1`msPKI-Key-Security-Descriptor`PZPWSTR`D:P(A;;FA;;;BA)(A;;FA;;;SY)(A;;GR;;;S-1-5-80-3804348527-3718992918-2141599610-3686422417-2726379419)`msPKI-Key-Usage`DWORD`2`msPKI-RA-Application-Policies`PZPWSTR`1.3.6.1.4.1.311.20.2.1`"
],

as they are now parsed so we only get the OID values like in syntax 1 output:

"applicationpolicies": [
      "1.3.6.1.4.1.311.20.2.1"
],

@rvazarkar rvazarkar merged commit fb9b86c into v3 Jan 19, 2024
3 checks passed
@rvazarkar rvazarkar deleted the BED-3936-app-policies-parsing branch January 19, 2024 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants