Changed template function setstatuscode to accept strings instead of int #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommysitu
approved these changes
Jul 20, 2024
|
Thanks Tommy!
Would you be able to release into Hoverfly Cloud Dev?
Regards
Stu
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Tommy Situ ***@***.***>
Sent: Saturday, July 20, 2024 12:15:15 PM
To: SpectoLabs/hoverfly ***@***.***>
Cc: Stuart Kelly ***@***.***>; Author ***@***.***>
Subject: Re: [SpectoLabs/hoverfly] Changed template function setstatuscode to accept strings instead of int (PR #1139)
Merged #1139<#1139> into master.
—
Reply to this email directly, view it on GitHub<#1139 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BADDXRKFQC7WQ4CNMVZJTE3ZNJBEHAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGU4DSMZVGI3TOMQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Note:
This message is for the named person's use only. It may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you receive this message in error, please immediately delete it and all copies of it from your system, destroy any hard copies of it and notify the sender. You must not, directly or indirectly, use, disclose, distribute, print, or copy any part of this message if you are not the intended recipient. EOH and any of its subsidiaries each reserve the right to monitor all e-mail communications through its networks.
Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of any such entity.
Thank You.
|
|
Sure I got a couple bug fix to do with hoverfly first.
On 20 Jul 2024, at 2:27 PM, stuioco ***@***.***> wrote:
Thanks Tommy!
Would you be able to release into Hoverfly Cloud Dev?
Regards
Stu
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Tommy Situ ***@***.***>
Sent: Saturday, July 20, 2024 12:15:15 PM
To: SpectoLabs/hoverfly ***@***.***>
Cc: Stuart Kelly ***@***.***>; Author ***@***.***>
Subject: Re: [SpectoLabs/hoverfly] Changed template function setstatuscode to accept strings instead of int (PR #1139)
Merged #1139<#1139> into master.
—
Reply to this email directly, view it on GitHub<#1139 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BADDXRKFQC7WQ4CNMVZJTE3ZNJBEHAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGU4DSMZVGI3TOMQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Note:
This message is for the named person's use only. It may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you receive this message in error, please immediately delete it and all copies of it from your system, destroy any hard copies of it and notify the sender. You must not, directly or indirectly, use, disclose, distribute, print, or copy any part of this message if you are not the intended recipient. EOH and any of its subsidiaries each reserve the right to monitor all e-mail communications through its networks.
Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of any such entity.
Thank You.
—
Reply to this email directly, view it on GitHub<#1139 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB2RAR3A3B5EBJTJBEMPZQ3ZNJQSZAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGE2TEMJYHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
It should be ready by Monday
On 20 Jul 2024, at 2:27 PM, stuioco ***@***.***> wrote:
Thanks Tommy!
Would you be able to release into Hoverfly Cloud Dev?
Regards
Stu
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Tommy Situ ***@***.***>
Sent: Saturday, July 20, 2024 12:15:15 PM
To: SpectoLabs/hoverfly ***@***.***>
Cc: Stuart Kelly ***@***.***>; Author ***@***.***>
Subject: Re: [SpectoLabs/hoverfly] Changed template function setstatuscode to accept strings instead of int (PR #1139)
Merged #1139<#1139> into master.
—
Reply to this email directly, view it on GitHub<#1139 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BADDXRKFQC7WQ4CNMVZJTE3ZNJBEHAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGU4DSMZVGI3TOMQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Note:
This message is for the named person's use only. It may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you receive this message in error, please immediately delete it and all copies of it from your system, destroy any hard copies of it and notify the sender. You must not, directly or indirectly, use, disclose, distribute, print, or copy any part of this message if you are not the intended recipient. EOH and any of its subsidiaries each reserve the right to monitor all e-mail communications through its networks.
Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of any such entity.
Thank You.
—
Reply to this email directly, view it on GitHub<#1139 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB2RAR3A3B5EBJTJBEMPZQ3ZNJQSZAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGE2TEMJYHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Thanks!
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Tommy Situ ***@***.***>
Sent: Saturday, July 20, 2024 2:31:43 PM
To: SpectoLabs/hoverfly ***@***.***>
Cc: Stuart Kelly ***@***.***>; Author ***@***.***>
Subject: Re: [SpectoLabs/hoverfly] Changed template function setstatuscode to accept strings instead of int (PR #1139)
It should be ready by Monday
On 20 Jul 2024, at 2:27 PM, stuioco ***@***.***> wrote:
Thanks Tommy!
Would you be able to release into Hoverfly Cloud Dev?
Regards
Stu
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Tommy Situ ***@***.***>
Sent: Saturday, July 20, 2024 12:15:15 PM
To: SpectoLabs/hoverfly ***@***.***>
Cc: Stuart Kelly ***@***.***>; Author ***@***.***>
Subject: Re: [SpectoLabs/hoverfly] Changed template function setstatuscode to accept strings instead of int (PR #1139)
Merged #1139<#1139<https://github.com/SpectoLabs/hoverfly/pull/1139>> into master.
—
Reply to this email directly, view it on GitHub<#1139 (comment)<https://github.com/SpectoLabs/hoverfly/pull/1139#event-13589352772>>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BADDXRKFQC7WQ4CNMVZJTE3ZNJBEHAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGU4DSMZVGI3TOMQ<https://github.com/notifications/unsubscribe-auth/BADDXRKFQC7WQ4CNMVZJTE3ZNJBEHAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGU4DSMZVGI3TOMQ>>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Note:
This message is for the named person's use only. It may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you receive this message in error, please immediately delete it and all copies of it from your system, destroy any hard copies of it and notify the sender. You must not, directly or indirectly, use, disclose, distribute, print, or copy any part of this message if you are not the intended recipient. EOH and any of its subsidiaries each reserve the right to monitor all e-mail communications through its networks.
Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of any such entity.
Thank You.
—
Reply to this email directly, view it on GitHub<#1139 (comment)<https://github.com/SpectoLabs/hoverfly/pull/1139#issuecomment-2241152189>>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB2RAR3A3B5EBJTJBEMPZQ3ZNJQSZAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGE2TEMJYHE<https://github.com/notifications/unsubscribe-auth/AB2RAR3A3B5EBJTJBEMPZQ3ZNJQSZAVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGE2TEMJYHE>>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub<#1139 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BADDXRJE7DKDOZ6PES6Y5Z3ZNJRD7AVCNFSM6AAAAABLFZOVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGE2TGMZSGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Note:
This message is for the named person's use only. It may contain confidential, proprietary or legally privileged information. No confidentiality or privilege is waived or lost by any mistransmission. If you receive this message in error, please immediately delete it and all copies of it from your system, destroy any hard copies of it and notify the sender. You must not, directly or indirectly, use, disclose, distribute, print, or copy any part of this message if you are not the intended recipient. EOH and any of its subsidiaries each reserve the right to monitor all e-mail communications through its networks.
Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of any such entity.
Thank You.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the template function setStatusCode to accept strings so that the status code can be generated from an internally nested function, like {{csv}}.
This will now work whereas it crashed before:
{{setStatusCode (csv 'gdcm-provisioning-data' 'Vin' (Request.Body 'jsonpath' '$.Vin') 'Response-Code')}}
I could not find any tests for it so I have not updated the tests.
Thanks
Stu