bugfix - resolve issue #1155 #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommysitu
reviewed
Nov 30, 2024
core/util/util.go
Outdated
Comment on lines
402
to
409
| //// Jsonpath library converts large int into a string with scientific notion, the following | ||
| //// reverts that process to avoid mismatching when using the jsonpath result for csv data lookup | ||
| //floatResult, err := strconv.ParseFloat(result, 64) | ||
| //// if the string is a float and a whole number | ||
| //if err == nil && floatResult == float64(int64(floatResult)) { | ||
| // intResult := int(floatResult) | ||
| // result = strconv.Itoa(intResult) | ||
| //} |
There was a problem hiding this comment.
but this introduces another issue...
There was a problem hiding this comment.
This is not correct way to do things. I am not sure why we added this bad alternative to that problem.
There was a problem hiding this comment.
so what would be the correct way?
There was a problem hiding this comment.
@tommysitu is that change still needed?
There was a problem hiding this comment.
yes, it's needed. By commenting it out, several tests will fail, eg. Test_ApplyTemplate_PutAndGetValue
There was a problem hiding this comment.
@tommysitu I have added handling for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1155