fixes #237

made a few changes to SearchForOrganizationsAsync
Speedygeek · Sep 16, 2016 · 69056df · 69056df
1 parent 3efd572
commit 69056df
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 17 deletions.
diff --git a/src/Tests/OrganizationTests.cs b/src/Tests/OrganizationTests.cs
@@ -5,6 +5,7 @@
 using ZendeskApi_v2.Models.Organizations;
 using ZendeskApi_v2.Models.Tags;
 using ZendeskApi_v2.Models.Users;
+using System.Threading.Tasks;
 
 namespace Tests
 {
@@ -167,5 +168,13 @@ public void CanCreateManyAndDeleteOrganizationMemberships()
             Assert.True(api.Organizations.DeleteOrganization(org.Organization.Id.Value));
             Assert.True(api.Organizations.DeleteOrganization(org2.Organization.Id.Value));
         }
+
+
+        [Test]
+        public async Task CanSearchForOrganizationsAsync()
+        {
+            var search = await api.Organizations.SearchForOrganizationsAsync(Settings.DefaultExternalId);
+            Assert.Greater(search.Count, 0);
+        }
     }
 }
diff --git a/src/Tests/TicketTests.cs b/src/Tests/TicketTests.cs
@@ -306,18 +306,6 @@ public async Task CanGetMultipleTicketsAsyncSingleTicket()
             Assert.AreEqual(tickets.Count, ids.Count);
         }
 
-        [Test]
-        public void CorrectErrorMessagesAreThrown()
-        {
-            //var t = api.Tickets.GetTicket(921);
-            //var res = api.Tickets.UpdateTicket(t.Ticket,
-            //                                   new Comment()
-            //                                       {
-            //                                           Body = "trying to cause an error by updating a closed ticket. Let's see how it responds :)"                                                           
-            //                                       });
-
-        }
-
         [Test]
         public void BooleanCustomFieldValuesArePreservedOnUpdate()
         {

diff --git a/src/ZendeskApi_v2/Requests/Organizations.cs b/src/ZendeskApi_v2/Requests/Organizations.cs
@@ -50,6 +50,7 @@ public interface IOrganizations : ICore
         /// <returns></returns>
         Task<GroupOrganizationResponse> GetOrganizationsStartingWithAsync(string name);
 
+        // TODO: Rename SearchForOrganizationsByExternalIdAsync(string externalId);
         Task<GroupOrganizationResponse> SearchForOrganizationsAsync(string searchTerm);
         Task<IndividualOrganizationResponse> GetOrganizationAsync(long id);
         Task<IndividualOrganizationResponse> CreateOrganizationAsync(Organization organization);
@@ -106,7 +107,7 @@ public IndividualOrganizationResponse GetOrganization(long id)
 
         public IndividualOrganizationResponse CreateOrganization(Organization organization)
         {
-            var body = new {organization};
+            var body = new { organization };
             return GenericPost<IndividualOrganizationResponse>("organizations.json", body);
         }
 
@@ -117,7 +118,7 @@ public IndividualOrganizationResponse UpdateOrganization(Organization organizati
         }
 
         public bool DeleteOrganization(long id)
-        {            
+        {
             return GenericDelete(string.Format("organizations/{0}.json", id));
         }
 
@@ -205,7 +206,7 @@ public async Task<GroupOrganizationResponse> GetOrganizationsStartingWithAsync(s
 
         public async Task<GroupOrganizationResponse> SearchForOrganizationsAsync(string searchTerm)
         {
-            return await GenericPostAsync<GroupOrganizationResponse>(string.Format("organizations/autocomplete.json?external_id={0}", searchTerm));
+            return await GenericGetAsync<GroupOrganizationResponse>(string.Format("organizations/search.json?external_id={0}", searchTerm));
         }
 
         public async Task<IndividualOrganizationResponse> GetOrganizationAsync(long id)
@@ -215,7 +216,7 @@ public async Task<IndividualOrganizationResponse> GetOrganizationAsync(long id)
 
         public async Task<IndividualOrganizationResponse> CreateOrganizationAsync(Organization organization)
         {
-            var body = new {organization};
+            var body = new { organization };
             return await GenericPostAsync<IndividualOrganizationResponse>("organizations.json", body);
         }
 
@@ -226,7 +227,7 @@ public async Task<IndividualOrganizationResponse> UpdateOrganizationAsync(Organi
         }
 
         public async Task<bool> DeleteOrganizationAsync(long id)
-        {            
+        {
             return await GenericDeleteAsync(string.Format("organizations/{0}.json", id));
         }