Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Updates #29

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Assorted Updates #29

wants to merge 19 commits into from

Conversation

dbetz
Copy link

@dbetz dbetz commented Aug 26, 2016

I've done a few things on my fork:

  1. Added handling of the recon callback to indicate a connection failure.
  2. Added a way for a cgi function to determine why it was called.
  3. Used the "reverse" field of espconn instead of looking up the IP address and port number.
  4. Added a prototype for httpdCgiIsDone.
  5. Added a function to join a wi-fi network.
  6. Fixed a problem in WebSocket broadcasts.
  7. Probably some other stuff that I can't recall anymore. :-(

@morganrallen
Copy link
Contributor

This is a pretty big PR. As it's already in conflict maybe you should consider resubmitting as multiple concise PRs.

For example, all the the typo-like, adding const and general cleanup can be a single cleanup PR. Then make a single PR for each feature you're adding. That will make this PR much easier to review, hopefully give you a better idea of what all you've done (point 7) and increase the likelihood each PR being conflict free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants