-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted Updates #29
base: master
Are you sure you want to change the base?
Assorted Updates #29
Conversation
This is a pretty big PR. As it's already in conflict maybe you should consider resubmitting as multiple concise PRs. For example, all the the typo-like, adding const and general cleanup can be a single cleanup PR. Then make a single PR for each feature you're adding. That will make this PR much easier to review, hopefully give you a better idea of what all you've done (point 7) and increase the likelihood each PR being conflict free. |
end up scanning in the wrong mode due to the delay between cgiWiFiSetMode and when the mode is actually set.
I've done a few things on my fork: