Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.2.0 #47
base: master
Are you sure you want to change the base?
V2.2.0 #47
Changes from 30 commits
bc666a7
91b6566
67620f0
3cd58ed
394f93f
929a018
a55d1ee
a376c7a
966853e
59abe03
69cf6d4
223c48f
a4c4c7b
348721e
a6092a7
7788189
f35fe21
c5b0295
629bb61
be2b512
343458f
5bc19a1
26fa095
9aa47de
b4a100a
a9410ee
df509a2
9476365
8626229
5830938
0a8f5ea
50ba270
980ec06
96030fd
38e6238
5e12799
734e098
6e253b5
190b097
c22ec01
bf07568
8591b30
eb49fa1
f95d241
0b91d7e
84e5c1d
a43734a
89fb9a6
4187e34
343e7f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see a parameter organization in the yaml. It looks like in the python code, that owner is being passed as organisation to the get_team_id - so that parameters in the example and the yaml don't seem to match.
Also yaml says environment is required parameter with no default, yet its not used in the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I have rewritten this and tested the call, it seems to be okay now :)
still pending to push the code though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example uses a parameter called organization, but the yaml states that the parameter is called org.