Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product.ts to fix TS error #56

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Jan 2, 2025

Updates product.ts to fix TS error on rancher/dashboard#12952 + https://github.com/rancher/dashboard/actions/runs/12506112573/job/34890542483?pr=12952

There is no label property on ProductOptions and it doesn't do anything. We should clean it up in order for the pipeline to pass

Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: e886d6e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@owanturist owanturist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hierynomus
Copy link
Contributor

Approved

@owanturist owanturist merged commit ebd7f67 into StackVista:main Jan 6, 2025
3 checks passed
owanturist added a commit that referenced this pull request Jan 8, 2025
* Update product.ts

* Create changeset

---------

Co-authored-by: Anton Ovechkin <[email protected]>
owanturist added a commit that referenced this pull request Jan 8, 2025
* Update product.ts

* Create changeset

---------

Co-authored-by: Anton Ovechkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants