Made the addition column clearer

(I hope) Signed-off-by: nigel brown <[email protected]>
StacklokLabs · May 17, 2024 · 73dc706 · 73dc706
1 parent 6e5d1fb
commit 73dc706
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 13 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/trusty.ts b/src/trusty.ts
@@ -166,7 +166,6 @@ function nameAndLink(change: Change, endpoint: string): string {
 
 // Function to determine the delta icon for a change
 function delta(change: Change, config: ConfigurationOptions): string {
-  const ct = {added: icons.plus, removed: icons.minus}
   let icon = icons.check
   const score = change?.trusty?.score || 0
   if (change.change_type === 'added') {
@@ -177,7 +176,17 @@ function delta(change: Change, config: ConfigurationOptions): string {
       icon = icons.cross
     }
   }
-  return `${ct[change.change_type]}${icon}`
+  return `${icon} ${change.change_type} `
+}
+
+// Return the change compiled as a string
+function dependencyChange(
+  change: Change,
+  config: ConfigurationOptions
+): string {
+  const action = delta(change, config)
+  const name = nameAndLink(change, config.trusty_ui)
+  return `${action} ${name}`
 }
 
 // Function to convert a change to a summary table row
@@ -186,8 +195,7 @@ function changeAsRow(
   config: ConfigurationOptions
 ): SummaryTableRow {
   const row: SummaryTableRow = [
-    delta(change, config),
-    nameAndLink(change, config.trusty_ui),
+    dependencyChange(change, config),
     change.version,
     change.trusty?.score?.toString() || '',
     change.trusty?.description?.malicious || false ? icons.cross : icons.check,
@@ -210,8 +218,7 @@ function changesAsTable(
   config: ConfigurationOptions
 ): SummaryTableRow[] {
   const headings = [
-    '+/-',
-    'Package',
+    'Dependency Change',
     'Version',
     'Score',
     'Not Malicious',