Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify action implementation, only use stable versions #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 24, 2024

Simplify action implementation, only use stable versions

♻️ Current situation & Problem

The current SwiftLint action usually checks out the main branch to make sure to use a current version of SwiftLint. However, the latest swiftlint docker image uses the main branch and doesn't point to the latest stable/released version.
This PR rewrites the action to be simple steps that download the GitHub artifacts from the latest GitHub version tag. This makes sure that we always have a current SwiftLint version, but only ever use a distributed version.

⚙️ Release Notes

  • Simplify action implementation.
  • Latest SwiftLint action now uses the latest release instead of the latest version on the main branch.

✅ Testing

Tested with actions. Note, minimum required ubuntu version is 22.04.
We also tested this in a SpeziAccount PR, see StanfordSpezi/SpeziAccount@5941870.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg changed the title Always use the latest version and not main Simplify action implementation, only use stable versions Nov 24, 2024
@Supereg Supereg marked this pull request as ready for review November 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant