Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix for npe NormalizePredicateRule #52326

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

ikishore
Copy link
Contributor

@ikishore ikishore commented Oct 25, 2024

Why I'm doing:

Fix for null pointer exception, when there are no nested children

What I'm doing:

Added null check, No side effect on functionality

Fixes #issue #52167

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ikishore ikishore requested a review from a team as a code owner October 25, 2024 07:23
@ikishore ikishore changed the title [Bugfix] Fix for npe NormalizePredicateRule [BugFix] Fix for npe NormalizePredicateRule Oct 25, 2024
@kangkaisen
Copy link
Collaborator

please add the UT, thanks.

Copy link

sonarcloud bot commented Nov 4, 2024

Copy link

github-actions bot commented Nov 4, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 4, 2024

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/scalar/NormalizePredicateRule.java 2 2 100.00% []

Copy link

github-actions bot commented Nov 4, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@ikishore
Copy link
Contributor Author

ikishore commented Nov 4, 2024

please add the UT, thanks.

@kangkaisen Please review. UT case added

@Seaven Seaven merged commit fa29610 into StarRocks:main Nov 21, 2024
48 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Nov 21, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 21, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 21, 2024
Signed-off-by: Kishore Kumar M V <[email protected]>
(cherry picked from commit fa29610)
mergify bot pushed a commit that referenced this pull request Nov 21, 2024
Signed-off-by: Kishore Kumar M V <[email protected]>
(cherry picked from commit fa29610)
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants