Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support alter table add roll up in shared data #53153

Merged
merged 3 commits into from
Nov 26, 2024
Merged

[Enhancement] Support alter table add roll up in shared data #53153

merged 3 commits into from
Nov 26, 2024
+85 −14

Conversation

smartlxh
Copy link
Contributor

@smartlxh smartlxh commented Nov 23, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

fixes #53165

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@smartlxh smartlxh requested a review from a team as a code owner November 23, 2024 14:53
@smartlxh smartlxh changed the title [Feature] Support alter table add roll up in shard data [Enhancement] Support alter table add roll up in shard data Nov 23, 2024
@github-actions github-actions bot added the 3.4 label Nov 23, 2024
@kevincai kevincai changed the title [Enhancement] Support alter table add roll up in shard data [Enhancement] Support alter table add roll up in shared data Nov 25, 2024
@smartlxh
add test
4895273 
Signed-off-by: smartlxh <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wyb wyb enabled auto-merge (squash) November 26, 2024 04:21
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit e6b2586 into StarRocks:main Nov 26, 2024
50 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Nov 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 26, 2024
@smartlxh @mergify
[Enhancement] Support alter table add roll up in shared data (#53153)
5cbf1f8 
Signed-off-by: smartlxh <[email protected]>
(cherry picked from commit e6b2586)
@mergify mergify bot mentioned this pull request Nov 26, 2024
Open
42 tasks
@smartlxh smartlxh deleted the lake_alter_rollup branch November 26, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@wyb wyb wyb approved these changes

Assignees

@smartlxh smartlxh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support alter table add roll up in shared data
3 participants
@smartlxh @wyb @gengjun-git