Bump rubocop from 1.65.0 to 1.65.1 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
gem compare racc 1.8.0 1.8.1Compared versions: ["1.8.0", "1.8.1"]
DIFFERENT date:
1.8.0: 2024-05-20 00:00:00 UTC
1.8.1: 2024-07-30 00:00:00 UTC
DIFFERENT description:
1.8.0: Racc is a LALR(1) parser generator.
It is written in Ruby itself, and generates Ruby program.
NOTE: Ruby 1.8.x comes with Racc runtime module. You
can run your parsers generated by racc 1.4.x out of the
box.
1.8.1: Racc is an LALR(1) parser generator.
It is written in Ruby itself, and generates Ruby program.
NOTE: Ruby 1.8.x comes with Racc runtime module. You
can run your parsers generated by racc 1.4.x out of the
box.
DIFFERENT metadata:
1.8.0: {}
1.8.1: {"changelog_uri"=>"https://github.com/ruby/racc/releases"}
DIFFERENT require_paths:
1.8.0: ["/opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/gems/3.2.0/extensions/x86_64-linux/3.2.0/racc-1.8.0", "lib"]
1.8.1: ["/opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/gems/3.2.0/extensions/x86_64-linux/3.2.0/racc-1.8.1", "lib"]
DIFFERENT summary:
1.8.0: Racc is a LALR(1) parser generator
1.8.1: Racc is an LALR(1) parser generator
DIFFERENT version:
1.8.0: 1.8.0
1.8.1: 1.8.1
DIFFERENT files:
1.8.0->1.8.1:
* Added:
BSDL +22/-0
* Changed:
COPYING +55/-21
README.rdoc +1/-1
lib/racc.rb +6/-6
lib/racc/grammar.rb +5/-5
lib/racc/grammarfileparser.rb +8/-8
lib/racc/info.rb +1/-1
lib/racc/parser-text.rb +2/-2
lib/racc/parser.rb +1/-1
lib/racc/parserfilegenerator.rb +3/-3
lib/racc/state.rb +3/-3
lib/racc/statetransitiontable.rb +1/-1
lib/racc/static.rb +5/-5
DIFFERENT extra_rdoc_files:
1.8.0->1.8.1:
* Changed:
README.rdoc +1/-1 |
gem compare --diff racc 1.8.0 1.8.1Compared versions: ["1.8.0", "1.8.1"]
DIFFERENT files:
1.8.0->1.8.1:
* Added:
BSDL
--- /tmp/20240802-1859-qzuc56 2024-08-02 02:49:07.191605662 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/BSDL 2024-08-02 02:49:07.183605618 +0000
@@ -0,0 +1,22 @@
+Copyright (C) 1993-2013 Yukihiro Matsumoto. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+SUCH DAMAGE.
* Changed:
COPYING
--- /tmp/d20240802-1859-u59935/racc-1.8.0/COPYING 2024-08-02 02:49:07.179605596 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/COPYING 2024-08-02 02:49:07.183605618 +0000
@@ -1 +1,3 @@
-Copyright (C) 2019 Yukihiro Matsumoto. All rights reserved.
+Ruby is copyrighted free software by Yukihiro Matsumoto <matz@netlab.jp>.
+You can redistribute it and/or modify it under either the terms of the
+2-clause BSDL (see the file BSDL), or the conditions below:
@@ -3,20 +5,52 @@
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-1. Redistributions of source code must retain the above copyright
-notice, this list of conditions and the following disclaimer.
-2. Redistributions in binary form must reproduce the above copyright
-notice, this list of conditions and the following disclaimer in the
-documentation and/or other materials provided with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
-OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
-HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
-SUCH DAMAGE.
+1. You may make and give away verbatim copies of the source form of the
+ software without restriction, provided that you duplicate all of the
+ original copyright notices and associated disclaimers.
+
+2. You may modify your copy of the software in any way, provided that
+ you do at least ONE of the following:
+
+ a. place your modifications in the Public Domain or otherwise
+ make them Freely Available, such as by posting said
+ modifications to Usenet or an equivalent medium, or by allowing
+ the author to include your modifications in the software.
+
+ b. use the modified software only within your corporation or
+ organization.
+
+ c. give non-standard binaries non-standard names, with
+ instructions on where to get the original software distribution.
+
+ d. make other distribution arrangements with the author.
+
+3. You may distribute the software in object code or binary form,
+ provided that you do at least ONE of the following:
+
+ a. distribute the binaries and library files of the software,
+ together with instructions (in the manual page or equivalent)
+ on where to get the original distribution.
+
+ b. accompany the distribution with the machine-readable source of
+ the software.
+
+ c. give non-standard binaries non-standard names, with
+ instructions on where to get the original software distribution.
+
+ d. make other distribution arrangements with the author.
+
+4. You may modify and include the part of the software into any other
+ software (possibly commercial). But some files in the distribution
+ are not written by the author, so that they are not under these terms.
+
+ For the list of those files and their copying conditions, see the
+ file LEGAL.
+
+5. The scripts and library files supplied as input to or produced as
+ output from the software do not automatically fall under the
+ copyright of the software, but belong to whomever generated them,
+ and may be sold commercially, and may be aggregated with this
+ software.
+
+6. THIS SOFTWARE IS PROVIDED "AS IS" AND WITHOUT ANY EXPRESS OR
+ IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED
+ WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ PURPOSE.
README.rdoc
--- /tmp/d20240802-1859-u59935/racc-1.8.0/README.rdoc 2024-08-02 02:49:07.179605596 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/README.rdoc 2024-08-02 02:49:07.187605639 +0000
@@ -7 +7 @@
- Racc is a LALR(1) parser generator.
+ Racc is an LALR(1) parser generator.
lib/racc.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc.rb 2024-08-02 02:49:07.187605639 +0000
@@ -1,6 +1,6 @@
-require 'racc/compat'
-require 'racc/debugflags'
-require 'racc/grammar'
-require 'racc/state'
-require 'racc/exception'
-require 'racc/info'
+require_relative 'racc/compat'
+require_relative 'racc/debugflags'
+require_relative 'racc/grammar'
+require_relative 'racc/state'
+require_relative 'racc/exception'
+require_relative 'racc/info'
lib/racc/grammar.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/grammar.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/grammar.rb 2024-08-02 02:49:07.187605639 +0000
@@ -13,5 +13,5 @@
-require 'racc/compat'
-require 'racc/iset'
-require 'racc/sourcetext'
-require 'racc/logfilegenerator'
-require 'racc/exception'
+require_relative 'compat'
+require_relative 'iset'
+require_relative 'sourcetext'
+require_relative 'logfilegenerator'
+require_relative 'exception'
lib/racc/grammarfileparser.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/grammarfileparser.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/grammarfileparser.rb 2024-08-02 02:49:07.187605639 +0000
@@ -13,5 +13,5 @@
-require 'racc'
-require 'racc/compat'
-require 'racc/grammar'
-require 'racc/parserfilegenerator'
-require 'racc/sourcetext'
+require_relative '../racc'
+require_relative 'compat'
+require_relative 'grammar'
+require_relative 'parserfilegenerator'
+require_relative 'sourcetext'
@@ -298 +298 @@
- src = SourceText.new("result = val[1] ? val[1].unshift(val[0]) : val", __FILE__, __LINE__)
+ src = SourceText.new("result = val[1] ? val[1].unshift(val[0]) : val", @filename, @scanner.lineno + 1)
@@ -311 +311 @@
- src = SourceText.new("result = val[1] ? val[1].unshift(val[0]) : val", __FILE__, __LINE__)
+ src = SourceText.new("result = val[1] ? val[1].unshift(val[0]) : val", @filename, @scanner.lineno + 1)
@@ -326 +326 @@
- src = SourceText.new("result = val", __FILE__, __LINE__)
+ src = SourceText.new("result = val", @filename, @scanner.lineno + 1)
lib/racc/info.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/info.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/info.rb 2024-08-02 02:49:07.187605639 +0000
@@ -15 +15 @@
- VERSION = '1.8.0'
+ VERSION = '1.8.1'
lib/racc/parser-text.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/parser-text.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/parser-text.rb 2024-08-02 02:49:07.191605662 +0000
@@ -18 +18 @@
- VERSION = '1.8.0'
+ VERSION = '1.8.1'
@@ -33 +33 @@
-# Racc is a LALR(1) parser generator.
+# Racc is an LALR(1) parser generator.
lib/racc/parser.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/parser.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/parser.rb 2024-08-02 02:49:07.191605662 +0000
@@ -22 +22 @@
-# Racc is a LALR(1) parser generator.
+# Racc is an LALR(1) parser generator.
lib/racc/parserfilegenerator.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/parserfilegenerator.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/parserfilegenerator.rb 2024-08-02 02:49:07.191605662 +0000
@@ -13,3 +13,3 @@
-require 'racc/compat'
-require 'racc/sourcetext'
-require 'racc/parser-text'
+require_relative 'compat'
+require_relative 'sourcetext'
+require_relative 'parser-text'
lib/racc/state.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/state.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/state.rb 2024-08-02 02:49:07.191605662 +0000
@@ -13,3 +13,3 @@
-require 'racc/iset'
-require 'racc/statetransitiontable'
-require 'racc/exception'
+require_relative 'iset'
+require_relative 'statetransitiontable'
+require_relative 'exception'
lib/racc/statetransitiontable.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/statetransitiontable.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/statetransitiontable.rb 2024-08-02 02:49:07.191605662 +0000
@@ -13 +13 @@
-require 'racc/parser'
+require_relative 'parser'
lib/racc/static.rb
--- /tmp/d20240802-1859-u59935/racc-1.8.0/lib/racc/static.rb 2024-08-02 02:49:07.183605618 +0000
+++ /tmp/d20240802-1859-u59935/racc-1.8.1/lib/racc/static.rb 2024-08-02 02:49:07.191605662 +0000
@@ -1,5 +1,5 @@
-require 'racc'
-require 'racc/parser'
-require 'racc/grammarfileparser'
-require 'racc/parserfilegenerator'
-require 'racc/logfilegenerator'
+require_relative '../racc'
+require_relative 'parser'
+require_relative 'grammarfileparser'
+require_relative 'parserfilegenerator'
+require_relative 'logfilegenerator' |
gem compare rexml 3.3.1 3.3.4Compared versions: ["3.3.1", "3.3.4"]
DIFFERENT date:
3.3.1: 2024-06-25 00:00:00 UTC
3.3.4: 2024-08-01 00:00:00 UTC
DIFFERENT metadata:
3.3.1: {"changelog_uri"=>"https://github.com/ruby/rexml/releases/tag/v3.3.1"}
3.3.4: {"changelog_uri"=>"https://github.com/ruby/rexml/releases/tag/v3.3.4"}
DIFFERENT version:
3.3.1: 3.3.1
3.3.4: 3.3.4
DIFFERENT files:
3.3.1->3.3.4:
* Changed:
NEWS.md +99/-0
lib/rexml/formatters/pretty.rb +1/-1
lib/rexml/parsers/baseparser.rb +68/-19
lib/rexml/parsers/pullparser.rb +4/-0
lib/rexml/parsers/sax2parser.rb +6/-19
lib/rexml/parsers/streamparser.rb +2/-2
lib/rexml/rexml.rb +1/-1
lib/rexml/source.rb +16/-6
lib/rexml/text.rb +34/-14
DIFFERENT extra_rdoc_files:
3.3.1->3.3.4:
* Changed:
NEWS.md +99/-0 |
gem compare --diff rexml 3.3.1 3.3.4Compared versions: ["3.3.1", "3.3.4"]
DIFFERENT files:
3.3.1->3.3.4:
* Changed:
NEWS.md
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/NEWS.md 2024-08-02 02:49:13.315639555 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/NEWS.md 2024-08-02 02:49:13.323639600 +0000
@@ -2,0 +3,99 @@
+## 3.3.4 - 2024-08-01 {#version-3-3-4}
+
+### Fixes
+
+ * Fixed a bug that `REXML::Security` isn't defined when
+ `REXML::Parsers::StreamParser` is used and
+ `rexml/parsers/streamparser` is only required.
+ * GH-189
+ * Patch by takuya kodama.
+
+### Thanks
+
+ * takuya kodama
+
+## 3.3.3 - 2024-08-01 {#version-3-3-3}
+
+### Improvements
+
+ * Added support for detecting invalid XML that has unsupported
+ content before root element
+ * GH-184
+ * Patch by NAITOH Jun.
+
+ * Added support for `REXML::Security.entity_expansion_limit=` and
+ `REXML::Security.entity_expansion_text_limit=` in SAX2 and pull
+ parsers
+ * GH-187
+ * Patch by NAITOH Jun.
+
+ * Added more tests for invalid XMLs.
+ * GH-183
+ * Patch by Watson.
+
+ * Added more performance tests.
+ * Patch by Watson.
+
+ * Improved parse performance.
+ * GH-186
+ * Patch by tomoya ishida.
+
+### Thanks
+
+ * NAITOH Jun
+
+ * Watson
+
+ * tomoya ishida
+
+## 3.3.2 - 2024-07-16 {#version-3-3-2}
+
+### Improvements
+
+ * Improved parse performance.
+ * GH-160
+ * Patch by NAITOH Jun.
+
+ * Improved parse performance.
+ * GH-169
+ * GH-170
+ * GH-171
+ * GH-172
+ * GH-173
+ * GH-174
+ * GH-175
+ * GH-176
+ * GH-177
+ * Patch by Watson.
+
+ * Added support for raising a parse exception when an XML has extra
+ content after the root element.
+ * GH-161
+ * Patch by NAITOH Jun.
+
+ * Added support for raising a parse exception when an XML
+ declaration exists in wrong position.
+ * GH-162
+ * Patch by NAITOH Jun.
+
+ * Removed needless a space after XML declaration in pretty print mode.
+ * GH-164
+ * Patch by NAITOH Jun.
+
+ * Stopped to emit `:text` event after the root element.
+ * GH-167
+ * Patch by NAITOH Jun.
+
+### Fixes
+
+ * Fixed a bug that SAX2 parser doesn't expand predefined entities for
+ `characters` callback.
+ * GH-168
+ * Patch by NAITOH Jun.
+
+### Thanks
+
+ * NAITOH Jun
+
+ * Watson
+
lib/rexml/formatters/pretty.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/formatters/pretty.rb 2024-08-02 02:49:13.319639578 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/formatters/pretty.rb 2024-08-02 02:49:13.331639646 +0000
@@ -114 +114 @@
- next if child == node.children[-1] and child.instance_of?(Text)
+ next if child.instance_of?(Text)
lib/rexml/parsers/baseparser.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/parsers/baseparser.rb 2024-08-02 02:49:13.319639578 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/parsers/baseparser.rb 2024-08-02 02:49:13.331639646 +0000
@@ -3,0 +4 @@
+require_relative '../security'
@@ -127 +127,0 @@
- INSTRUCTION_END = /#{NAME}(\s+.*?)?\?>/um
@@ -131 +131 @@
- NAME_PATTERN = /\s*#{NAME}/um
+ NAME_PATTERN = /#{NAME}/um
@@ -148,0 +149 @@
+ @entity_expansion_count = 0
@@ -155,0 +157 @@
+ attr_reader :entity_expansion_count
@@ -159,0 +162 @@
+ @have_root = false
@@ -242 +245 @@
- return process_instruction(start_position)
+ return process_instruction
@@ -312 +315,5 @@
- match = [:entitydecl, *@source.match(Private::ENTITYDECL_PATTERN, true).captures.compact]
+ match_data = @source.match(Private::ENTITYDECL_PATTERN, true)
+ unless match_data
+ raise REXML::ParseException.new("Malformed entity declaration", @source)
+ end
+ match = [:entitydecl, *match_data.captures.compact]
@@ -344 +351 @@
- values = md[0].scan( ATTDEF_RE )
+ values = md[0].strip.scan( ATTDEF_RE )
@@ -438 +445 @@
- return process_instruction(start_position)
+ return process_instruction
@@ -462,0 +470,3 @@
+ if @tags.empty? and @have_root
+ raise ParseException.new("Malformed XML: Extra tag at the end of the document (got '<#{tag}')", @source)
+ end
@@ -464,0 +475 @@
+ @have_root = true
@@ -471,0 +483,10 @@
+ if @tags.empty?
+ unless /\A\s*\z/.match?(text)
+ if @have_root
+ raise ParseException.new("Malformed XML: Extra content at the end of the document (got '#{text}')", @source)
+ else
+ raise ParseException.new("Malformed XML: Content at the start of the document (got '#{text}')", @source)
+ end
+ end
+ return pull_event if @have_root
+ end
@@ -489 +510,3 @@
- if not value
+ if value
+ record_entity_expansion
+ else
@@ -514 +537,5 @@
- rv = string.gsub( Private::CARRIAGE_RETURN_NEWLINE_PATTERN, "\n" )
+ if string.include?("\r")
+ rv = string.gsub( Private::CARRIAGE_RETURN_NEWLINE_PATTERN, "\n" )
+ else
+ rv = string.dup
+ end
@@ -523,0 +551 @@
+ sum = 0
@@ -529,0 +558,4 @@
+ sum += rv.bytesize
+ if sum > Security.entity_expansion_text_limit
+ raise "entity expansion has grown too large"
+ end
@@ -541,0 +574,8 @@
+
+ def record_entity_expansion
+ @entity_expansion_count += 1
+ if @entity_expansion_count > Security.entity_expansion_limit
+ raise "number of entity expansions exceeded, processing aborted."
+ end
+ end
+
@@ -551 +591 @@
- if @source.match(/\s*\S/um)
+ if @source.match(/\S/um)
@@ -558 +598 @@
- md[1]
+ md[0]
@@ -627,6 +667,13 @@
- def process_instruction(start_position)
- match_data = @source.match(Private::INSTRUCTION_END, true)
- unless match_data
- message = "Invalid processing instruction node"
- @source.position = start_position
- raise REXML::ParseException.new(message, @source)
+ def process_instruction
+ name = parse_name("Malformed XML: Invalid processing instruction node")
+ if @source.match(/\s+/um, true)
+ match_data = @source.match(/(.*?)\?>/um, true)
+ unless match_data
+ raise ParseException.new("Malformed XML: Unclosed processing instruction", @source)
+ end
+ content = match_data[1]
+ else
+ content = nil
+ unless @source.match("?>", true)
+ raise ParseException.new("Malformed XML: Unclosed processing instruction", @source)
+ end
@@ -634,2 +681,4 @@
- if @document_status.nil? and match_data[1] == "xml"
- content = match_data[2]
+ if name == "xml"
+ if @document_status
+ raise ParseException.new("Malformed XML: XML declaration is not at the start", @source)
+ end
@@ -650 +699 @@
- [:processing_instruction, match_data[1], match_data[2]]
+ [:processing_instruction, name, content]
lib/rexml/parsers/pullparser.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/parsers/pullparser.rb 2024-08-02 02:49:13.319639578 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/parsers/pullparser.rb 2024-08-02 02:49:13.331639646 +0000
@@ -49,0 +50,4 @@
+ def entity_expansion_count
+ @parser.entity_expansion_count
+ end
+
lib/rexml/parsers/sax2parser.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/parsers/sax2parser.rb 2024-08-02 02:49:13.319639578 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/parsers/sax2parser.rb 2024-08-02 02:49:13.331639646 +0000
@@ -24,0 +25,4 @@
+ def entity_expansion_count
+ @parser.entity_expansion_count
+ end
+
@@ -160,19 +164,2 @@
- #normalized = @parser.normalize( event[1] )
- #handle( :characters, normalized )
- copy = event[1].clone
-
- esub = proc { |match|
- if @entities.has_key?($1)
- @entities[$1].gsub(Text::REFERENCE, &esub)
- else
- match
- end
- }
-
- copy.gsub!( Text::REFERENCE, &esub )
- copy.gsub!( Text::NUMERICENTITY ) {|m|
- m=$1
- m = "0#{m}" if m[0] == ?x
- [Integer(m)].pack('U*')
- }
- handle( :characters, copy )
+ unnormalized = @parser.unnormalize( event[1], @entities )
+ handle( :characters, unnormalized )
lib/rexml/parsers/streamparser.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/parsers/streamparser.rb 2024-08-02 02:49:13.323639600 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/parsers/streamparser.rb 2024-08-02 02:49:13.331639646 +0000
@@ -39,2 +39,2 @@
- normalized = @parser.unnormalize( event[1] )
- @listener.text( normalized )
+ unnormalized = @parser.unnormalize( event[1] )
+ @listener.text( unnormalized )
lib/rexml/rexml.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/rexml.rb 2024-08-02 02:49:13.323639600 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/rexml.rb 2024-08-02 02:49:13.331639646 +0000
@@ -34 +34 @@
- VERSION = "3.3.1"
+ VERSION = "3.3.4"
lib/rexml/source.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/source.rb 2024-08-02 02:49:13.323639600 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/source.rb 2024-08-02 02:49:13.335639668 +0000
@@ -207 +207 @@
- def read(term = nil)
+ def read(term = nil, min_bytes = 1)
@@ -210 +210,11 @@
- @scanner << readline(term)
+ str = readline(term)
+ @scanner << str
+ read_bytes = str.bytesize
+ begin
+ while read_bytes < min_bytes
+ str = readline(term)
+ @scanner << str
+ read_bytes += str.bytesize
+ end
+ rescue IOError
+ end
@@ -240,3 +249,0 @@
- # Note: When specifying a string for 'pattern', it must not include '>' except in the following formats:
- # - ">"
- # - "XXX>" (X is any string excluding '>')
@@ -243,0 +251,2 @@
+ # To avoid performance issue, we need to increase bytes to read per scan
+ min_bytes = 1
@@ -253 +262,2 @@
- return nil unless read
+ return nil unless read(nil, min_bytes)
+ min_bytes *= 2
lib/rexml/text.rb
--- /tmp/d20240802-2007-2dn35o/rexml-3.3.1/lib/rexml/text.rb 2024-08-02 02:49:13.323639600 +0000
+++ /tmp/d20240802-2007-2dn35o/rexml-3.3.4/lib/rexml/text.rb 2024-08-02 02:49:13.335639668 +0000
@@ -154,8 +154,21 @@
- # context sensitive
- string.scan(pattern) do
- if $1[-1] != ?;
- raise "Illegal character #{$1.inspect} in raw string #{string.inspect}"
- elsif $1[0] == ?&
- if $5 and $5[0] == ?#
- case ($5[1] == ?x ? $5[2..-1].to_i(16) : $5[1..-1].to_i)
- when *VALID_CHAR
+ pos = 0
+ while (index = string.index(/<|&/, pos))
+ if string[index] == "<"
+ raise "Illegal character \"#{string[index]}\" in raw string #{string.inspect}"
+ end
+
+ unless (end_index = string.index(/[^\s];/, index + 1))
+ raise "Illegal character \"#{string[index]}\" in raw string #{string.inspect}"
+ end
+
+ value = string[(index + 1)..end_index]
+ if /\s/.match?(value)
+ raise "Illegal character \"#{string[index]}\" in raw string #{string.inspect}"
+ end
+
+ if value[0] == "#"
+ character_reference = value[1..-1]
+
+ unless (/\A(\d+|x[0-9a-fA-F]+)\z/.match?(character_reference))
+ if character_reference[0] == "x" || character_reference[-1] == "x"
+ raise "Illegal character \"#{string[index]}\" in raw string #{string.inspect}"
@@ -163 +176 @@
- raise "Illegal character #{$1.inspect} in raw string #{string.inspect}"
+ raise "Illegal character #{string.inspect} in raw string #{string.inspect}"
@@ -165,5 +177,0 @@
- # FIXME: below can't work but this needs API change.
- # elsif @parent and $3 and !SUBSTITUTES.include?($1)
- # if !doctype or !doctype.entities.has_key?($3)
- # raise "Undeclared entity '#{$1}' in raw string \"#{string}\""
- # end
@@ -170,0 +179,8 @@
+
+ case (character_reference[0] == "x" ? character_reference[1..-1].to_i(16) : character_reference[0..-1].to_i)
+ when *VALID_CHAR
+ else
+ raise "Illegal character #{string.inspect} in raw string #{string.inspect}"
+ end
+ elsif !(/\A#{Entity::NAME}\z/um.match?(value))
+ raise "Illegal character \"#{string[index]}\" in raw string #{string.inspect}"
@@ -171,0 +188,2 @@
+
+ pos = end_index + 1
@@ -172,0 +191,2 @@
+
+ string |
gem compare rubocop 1.65.0 1.65.1Compared versions: ["1.65.0", "1.65.1"]
DIFFERENT date:
1.65.0: 2024-07-10 00:00:00 UTC
1.65.1: 2024-08-01 00:00:00 UTC
DIFFERENT metadata:
1.65.0: {"homepage_uri"=>"https://rubocop.org/", "changelog_uri"=>"https://github.com/rubocop/rubocop/releases/tag/v1.65.0", "source_code_uri"=>"https://github.com/rubocop/rubocop/", "documentation_uri"=>"https://docs.rubocop.org/rubocop/1.65/", "bug_tracker_uri"=>"https://github.com/rubocop/rubocop/issues", "rubygems_mfa_required"=>"true"}
1.65.1: {"homepage_uri"=>"https://rubocop.org/", "changelog_uri"=>"https://github.com/rubocop/rubocop/releases/tag/v1.65.1", "source_code_uri"=>"https://github.com/rubocop/rubocop/", "documentation_uri"=>"https://docs.rubocop.org/rubocop/1.65/", "bug_tracker_uri"=>"https://github.com/rubocop/rubocop/issues", "rubygems_mfa_required"=>"true"}
DIFFERENT rubygems_version:
1.65.0: 3.4.22
1.65.1: 3.3.7
DIFFERENT version:
1.65.0: 1.65.0
1.65.1: 1.65.1
DIFFERENT files:
1.65.0->1.65.1:
* Changed:
lib/rubocop.rb +5/-0
lib/rubocop/cop/cop.rb +2/-2
lib/rubocop/cop/layout/assignment_indentation.rb +3/-2
lib/rubocop/cop/layout/condition_position.rb +0/-4
lib/rubocop/cop/lint/ambiguous_block_association.rb +0/-2
lib/rubocop/cop/lint/ambiguous_operator.rb +0/-2
lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +0/-2
lib/rubocop/cop/lint/boolean_symbol.rb +0/-2
lib/rubocop/cop/lint/circular_argument_reference.rb +0/-13
lib/rubocop/cop/lint/debugger.rb +0/-4
lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +0/-10
lib/rubocop/cop/lint/duplicate_case_condition.rb +0/-4
lib/rubocop/cop/lint/duplicate_hash_key.rb +0/-4
lib/rubocop/cop/lint/duplicate_methods.rb +0/-10
lib/rubocop/cop/lint/each_with_object_argument.rb +0/-4
lib/rubocop/cop/lint/else_layout.rb +0/-2
lib/rubocop/cop/lint/empty_ensure.rb +1/-11
lib/rubocop/cop/lint/empty_interpolation.rb +0/-4
lib/rubocop/cop/lint/empty_when.rb +0/-2
lib/rubocop/cop/lint/ensure_return.rb +1/-6
lib/rubocop/cop/lint/float_comparison.rb +3/-1
lib/rubocop/cop/lint/float_out_of_range.rb +0/-4
lib/rubocop/cop/lint/format_parameter_mismatch.rb +0/-10
lib/rubocop/cop/lint/implicit_string_concatenation.rb +1/-5
lib/rubocop/cop/lint/ineffective_access_modifier.rb +0/-7
lib/rubocop/cop/lint/interpolation_check.rb +0/-4
lib/rubocop/cop/lint/literal_assignment_in_condition.rb +1/-1
lib/rubocop/cop/lint/literal_in_interpolation.rb +0/-4
lib/rubocop/cop/lint/loop.rb +6/-12
lib/rubocop/cop/lint/nested_method_definition.rb +0/-6
lib/rubocop/cop/lint/next_without_accumulator.rb +0/-4
lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +0/-5
lib/rubocop/cop/lint/percent_string_array.rb +0/-4
lib/rubocop/cop/lint/percent_symbol_array.rb +0/-4
lib/rubocop/cop/lint/rand_one.rb +0/-4
lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +3/-1
lib/rubocop/cop/lint/redundant_splat_expansion.rb +1/-1
lib/rubocop/cop/lint/redundant_string_coercion.rb +0/-4
lib/rubocop/cop/lint/require_parentheses.rb +0/-4
lib/rubocop/cop/lint/rescue_exception.rb +0/-4
lib/rubocop/cop/lint/return_in_void_context.rb +0/-2
lib/rubocop/cop/lint/safe_navigation_chain.rb +0/-4
lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +6/-10
lib/rubocop/cop/lint/unified_integer.rb +0/-4
lib/rubocop/cop/lint/unreachable_code.rb +0/-5
lib/rubocop/cop/lint/useless_assignment.rb +1/-5
lib/rubocop/cop/lint/useless_else_without_rescue.rb +0/-4
lib/rubocop/cop/lint/useless_setter_call.rb +0/-4
lib/rubocop/cop/naming/predicate_name.rb +54/-28
lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +10/-1
lib/rubocop/cop/style/def_with_parentheses.rb +0/-2
lib/rubocop/cop/style/each_for_simple_loop.rb +0/-1
lib/rubocop/cop/style/eval_with_location.rb +12/-11
lib/rubocop/cop/style/file_read.rb +2/-5
lib/rubocop/cop/style/file_write.rb +2/-5
lib/rubocop/cop/style/global_std_stream.rb +7/-1
lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +0/-1
lib/rubocop/cop/style/invertible_unless_condition.rb +2/-2
lib/rubocop/cop/style/method_call_with_args_parentheses.rb +1/-1
lib/rubocop/cop/style/missing_else.rb +0/-4
lib/rubocop/cop/style/multiline_when_then.rb +0/-4
lib/rubocop/cop/style/redundant_condition.rb +0/-1
lib/rubocop/cop/style/redundant_regexp_escape.rb +7/-23
lib/rubocop/cop/style/sole_nested_conditional.rb +21/-2
lib/rubocop/cop/style/while_until_do.rb +0/-2
lib/rubocop/cop/style/while_until_modifier.rb +0/-1
lib/rubocop/cop/style/zero_length_predicate.rb +5/-1
lib/rubocop/cop/variable_force.rb +13/-1
lib/rubocop/core_ext/string.rb +2/-6
lib/rubocop/ext/regexp_node.rb +9/-31
lib/rubocop/options.rb +3/-1
lib/rubocop/version.rb +1/-1 |
gem compare --diff rubocop 1.65.0 1.65.1Compared versions: ["1.65.0", "1.65.1"]
DIFFERENT files:
1.65.0->1.65.1:
* Changed:
lib/rubocop.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop.rb 2024-08-02 02:49:20.959682091 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop.rb 2024-08-02 02:49:21.159683188 +0000
@@ -3,0 +4,5 @@
+
+# fileutils is autoloaded by pathname,
+# but must be explicitly loaded here for inclusion in `$LOADED_FEATURES`.
+require 'fileutils'
+
lib/rubocop/cop/cop.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/cop.rb 2024-08-02 02:49:20.967682135 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/cop.rb 2024-08-02 02:49:21.239683626 +0000
@@ -73 +73 @@
- if block.nil? && !support_autocorrect?
+ if block.nil? && !self.class.support_autocorrect?
@@ -157 +157 @@
- return unless support_autocorrect?
+ return unless self.class.support_autocorrect?
lib/rubocop/cop/layout/assignment_indentation.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/layout/assignment_indentation.rb 2024-08-02 02:49:20.975682179 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/layout/assignment_indentation.rb 2024-08-02 02:49:21.251683692 +0000
@@ -8,0 +9,3 @@
+ # The indentation of the remaining lines can be corrected with
+ # other cops such as `Layout/IndentationConsistency` and `Layout/EndAlignment`.
+ #
@@ -22,2 +24,0 @@
- # The indentation of the remaining lines can be corrected with
- # other cops such as `IndentationConsistency` and `EndAlignment`.
lib/rubocop/cop/layout/condition_position.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/layout/condition_position.rb 2024-08-02 02:49:20.975682179 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/layout/condition_position.rb 2024-08-02 02:49:21.251683692 +0000
@@ -12 +11,0 @@
- #
@@ -18,2 +16,0 @@
- # @example
- #
@@ -21 +17,0 @@
- #
lib/rubocop/cop/lint/ambiguous_block_association.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/ambiguous_block_association.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/ambiguous_block_association.rb 2024-08-02 02:49:21.263683758 +0000
@@ -17,2 +16,0 @@
- # @example
- #
lib/rubocop/cop/lint/ambiguous_operator.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/ambiguous_operator.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/ambiguous_operator.rb 2024-08-02 02:49:21.263683758 +0000
@@ -17,2 +16,0 @@
- # @example
- #
lib/rubocop/cop/lint/ambiguous_regexp_literal.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb 2024-08-02 02:49:21.263683758 +0000
@@ -18,2 +17,0 @@
- # @example
- #
lib/rubocop/cop/lint/boolean_symbol.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/boolean_symbol.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/boolean_symbol.rb 2024-08-02 02:49:21.263683758 +0000
@@ -22,2 +21,0 @@
- # @example
- #
lib/rubocop/cop/lint/circular_argument_reference.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/circular_argument_reference.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/circular_argument_reference.rb 2024-08-02 02:49:21.263683758 +0000
@@ -14 +13,0 @@
- #
@@ -19,2 +17,0 @@
- # @example
- #
@@ -22 +18,0 @@
- #
@@ -27,2 +22,0 @@
- # @example
- #
@@ -30 +23,0 @@
- #
@@ -35,2 +27,0 @@
- # @example
- #
@@ -38 +28,0 @@
- #
@@ -43,2 +32,0 @@
- # @example
- #
@@ -46 +33,0 @@
- #
lib/rubocop/cop/lint/debugger.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/debugger.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/debugger.rb 2024-08-02 02:49:21.267683780 +0000
@@ -47,2 +46,0 @@
- # @example
- #
@@ -56,2 +53,0 @@
- #
- # @example
lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb 2024-08-02 02:49:21.267683780 +0000
@@ -12,2 +11,0 @@
- # # Example for OpenSSL::Cipher instantiation.
- #
@@ -20,4 +17,0 @@
- # @example
- #
- # # Example for OpenSSL::Digest instantiation.
- #
@@ -29,4 +22,0 @@
- #
- # @example
- #
- # # Example for ::Digest inherited class methods.
lib/rubocop/cop/lint/duplicate_case_condition.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/duplicate_case_condition.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/duplicate_case_condition.rb 2024-08-02 02:49:21.267683780 +0000
@@ -12 +11,0 @@
- #
@@ -20,2 +18,0 @@
- # @example
- #
@@ -23 +19,0 @@
- #
lib/rubocop/cop/lint/duplicate_hash_key.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/duplicate_hash_key.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/duplicate_hash_key.rb 2024-08-02 02:49:21.267683780 +0000
@@ -14 +13,0 @@
- #
@@ -17,2 +15,0 @@
- # @example
- #
@@ -20 +16,0 @@
- #
lib/rubocop/cop/lint/duplicate_methods.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/duplicate_methods.rb 2024-08-02 02:49:20.991682267 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/duplicate_methods.rb 2024-08-02 02:49:21.267683780 +0000
@@ -12 +11,0 @@
- #
@@ -21,2 +19,0 @@
- # @example
- #
@@ -24 +20,0 @@
- #
@@ -31,2 +26,0 @@
- # @example
- #
@@ -34 +27,0 @@
- #
@@ -43,2 +35,0 @@
- # @example
- #
@@ -46 +36,0 @@
- #
lib/rubocop/cop/lint/each_with_object_argument.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/each_with_object_argument.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/each_with_object_argument.rb 2024-08-02 02:49:21.267683780 +0000
@@ -15 +14,0 @@
- #
@@ -18,2 +16,0 @@
- # @example
- #
@@ -21 +17,0 @@
- #
lib/rubocop/cop/lint/else_layout.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/else_layout.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/else_layout.rb 2024-08-02 02:49:21.267683780 +0000
@@ -24,2 +23,0 @@
- # @example
- #
lib/rubocop/cop/lint/empty_ensure.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/empty_ensure.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/empty_ensure.rb 2024-08-02 02:49:21.267683780 +0000
@@ -6 +6 @@
- # Checks for empty `ensure` blocks
+ # Checks for empty `ensure` blocks.
@@ -11 +10,0 @@
- #
@@ -17,2 +15,0 @@
- # @example
- #
@@ -20 +16,0 @@
- #
@@ -26,2 +21,0 @@
- # @example
- #
@@ -29 +22,0 @@
- #
@@ -36,2 +28,0 @@
- # @example
- #
@@ -39 +29,0 @@
- #
lib/rubocop/cop/lint/empty_interpolation.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/empty_interpolation.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/empty_interpolation.rb 2024-08-02 02:49:21.267683780 +0000
@@ -11 +10,0 @@
- #
@@ -14,2 +12,0 @@
- # @example
- #
@@ -17 +13,0 @@
- #
lib/rubocop/cop/lint/empty_when.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/empty_when.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/empty_when.rb 2024-08-02 02:49:21.267683780 +0000
@@ -17,2 +16,0 @@
- # @example
- #
lib/rubocop/cop/lint/ensure_return.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/ensure_return.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/ensure_return.rb 2024-08-02 02:49:21.267683780 +0000
@@ -16 +15,0 @@
- #
@@ -24,2 +22,0 @@
- # @example
- #
@@ -27 +23,0 @@
- #
@@ -35,2 +31 @@
- # # also good
- #
+ # # good
lib/rubocop/cop/lint/float_comparison.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/float_comparison.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/float_comparison.rb 2024-08-02 02:49:21.271683802 +0000
@@ -69 +69,3 @@
- node&.numeric_type? && node.value.zero?
+ # TODO: https://github.com/rubocop/rubocop-ast/pull/304 is released,
+ # replace this condition with `node&.numeric_type? && node.value.zero?`.
+ node&.numeric_type? && node.node_parts[0].zero?
lib/rubocop/cop/lint/float_out_of_range.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/float_out_of_range.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/float_out_of_range.rb 2024-08-02 02:49:21.271683802 +0000
@@ -13 +12,0 @@
- #
@@ -16,2 +14,0 @@
- # @example
- #
@@ -19 +15,0 @@
- #
lib/rubocop/cop/lint/format_parameter_mismatch.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/format_parameter_mismatch.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/format_parameter_mismatch.rb 2024-08-02 02:49:21.271683802 +0000
@@ -17 +16,0 @@
- #
@@ -20,2 +18,0 @@
- # @example
- #
@@ -23 +19,0 @@
- #
@@ -26,2 +21,0 @@
- # @example
- #
@@ -29 +22,0 @@
- #
@@ -32,2 +24,0 @@
- # @example
- #
@@ -35 +25,0 @@
- #
lib/rubocop/cop/lint/implicit_string_concatenation.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/implicit_string_concatenation.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/implicit_string_concatenation.rb 2024-08-02 02:49:21.271683802 +0000
@@ -12 +11,0 @@
- #
@@ -15,2 +13,0 @@
- # @example
- #
@@ -18 +14,0 @@
- #
@@ -83 +79 @@
- node.str_type? || (node.dstr_type? && node.children.all? { |c| string_literal?(c) })
+ node.str_type? || node.dstr_type?
lib/rubocop/cop/lint/ineffective_access_modifier.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/ineffective_access_modifier.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/ineffective_access_modifier.rb 2024-08-02 02:49:21.271683802 +0000
@@ -14 +13,0 @@
- #
@@ -23,2 +21,0 @@
- # @example
- #
@@ -26 +22,0 @@
- #
@@ -35,2 +30,0 @@
- # @example
- #
@@ -38 +31,0 @@
- #
lib/rubocop/cop/lint/interpolation_check.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/interpolation_check.rb 2024-08-02 02:49:20.995682289 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/interpolation_check.rb 2024-08-02 02:49:21.271683802 +0000
@@ -17 +16,0 @@
- #
@@ -20,2 +18,0 @@
- # @example
- #
@@ -23 +19,0 @@
- #
lib/rubocop/cop/lint/literal_assignment_in_condition.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/literal_assignment_in_condition.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/literal_assignment_in_condition.rb 2024-08-02 02:49:21.271683802 +0000
@@ -57 +57 @@
- yield node if AST::Node::EQUALS_ASSIGNMENTS.include?(node.type)
+ yield node if node.equals_asgn?
lib/rubocop/cop/lint/literal_in_interpolation.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/literal_in_interpolation.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/literal_in_interpolation.rb 2024-08-02 02:49:21.271683802 +0000
@@ -11 +10,0 @@
- #
@@ -14,2 +12,0 @@
- # @example
- #
@@ -17 +13,0 @@
- #
lib/rubocop/cop/lint/loop.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/loop.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/loop.rb 2024-08-02 02:49:21.271683802 +0000
@@ -22,11 +21,0 @@
- # @example
- #
- # # bad
- #
- # # using until
- # begin
- # do_something
- # end until some_condition
- #
- # @example
- #
@@ -41 +30,6 @@
- # @example
+ # # bad
+ #
+ # # using until
+ # begin
+ # do_something
+ # end until some_condition
lib/rubocop/cop/lint/nested_method_definition.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/nested_method_definition.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/nested_method_definition.rb 2024-08-02 02:49:21.271683802 +0000
@@ -20,2 +19,0 @@
- # @example
- #
@@ -29,2 +26,0 @@
- # @example
- #
@@ -49,2 +44,0 @@
- #
- # @example
lib/rubocop/cop/lint/next_without_accumulator.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/next_without_accumulator.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/next_without_accumulator.rb 2024-08-02 02:49:21.271683802 +0000
@@ -11 +10,0 @@
- #
@@ -17,2 +15,0 @@
- # @example
- #
@@ -20 +16,0 @@
- #
lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb 2024-08-02 02:49:21.271683802 +0000
@@ -14 +13,0 @@
- #
@@ -21,2 +19,0 @@
- # @example
- #
@@ -24 +20,0 @@
- #
@@ -34 +29,0 @@
- #
lib/rubocop/cop/lint/percent_string_array.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/percent_string_array.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/percent_string_array.rb 2024-08-02 02:49:21.275683823 +0000
@@ -25 +24,0 @@
- #
@@ -28,2 +26,0 @@
- # @example
- #
@@ -31 +27,0 @@
- #
lib/rubocop/cop/lint/percent_symbol_array.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/percent_symbol_array.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/percent_symbol_array.rb 2024-08-02 02:49:21.275683823 +0000
@@ -15 +14,0 @@
- #
@@ -18,2 +16,0 @@
- # @example
- #
@@ -21 +17,0 @@
- #
lib/rubocop/cop/lint/rand_one.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/rand_one.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/rand_one.rb 2024-08-02 02:49:21.275683823 +0000
@@ -12 +11,0 @@
- #
@@ -18,2 +16,0 @@
- # @example
- #
@@ -21 +17,0 @@
- #
lib/rubocop/cop/lint/redundant_cop_enable_directive.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb 2024-08-02 02:49:20.999682311 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb 2024-08-02 02:49:21.275683823 +0000
@@ -16,0 +17 @@
+ #
@@ -17,0 +19 @@
+ #
@@ -24 +26 @@
- # @example
+ #
lib/rubocop/cop/lint/redundant_splat_expansion.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/redundant_splat_expansion.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/redundant_splat_expansion.rb 2024-08-02 02:49:21.275683823 +0000
@@ -6 +6 @@
- # Checks for unneeded usages of splat expansion
+ # Checks for unneeded usages of splat expansion.
lib/rubocop/cop/lint/redundant_string_coercion.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/redundant_string_coercion.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/redundant_string_coercion.rb 2024-08-02 02:49:21.275683823 +0000
@@ -12 +11,0 @@
- #
@@ -18,2 +16,0 @@
- # @example
- #
@@ -21 +17,0 @@
- #
lib/rubocop/cop/lint/require_parentheses.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/require_parentheses.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/require_parentheses.rb 2024-08-02 02:49:21.275683823 +0000
@@ -18 +17,0 @@
- #
@@ -23,2 +21,0 @@
- # @example
- #
@@ -26 +22,0 @@
- #
lib/rubocop/cop/lint/rescue_exception.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/rescue_exception.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/rescue_exception.rb 2024-08-02 02:49:21.275683823 +0000
@@ -11 +10,0 @@
- #
@@ -18,2 +16,0 @@
- # @example
- #
@@ -21 +17,0 @@
- #
lib/rubocop/cop/lint/return_in_void_context.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/return_in_void_context.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/return_in_void_context.rb 2024-08-02 02:49:21.275683823 +0000
@@ -22,2 +21,0 @@
- # @example
- #
lib/rubocop/cop/lint/safe_navigation_chain.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/safe_navigation_chain.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/safe_navigation_chain.rb 2024-08-02 02:49:21.275683823 +0000
@@ -15 +14,0 @@
- #
@@ -20,2 +18,0 @@
- # @example
- #
@@ -23 +19,0 @@
- #
lib/rubocop/cop/lint/shadowing_outer_local_variable.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb 2024-08-02 02:49:21.003682333 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb 2024-08-02 02:49:21.279683845 +0000
@@ -15,6 +15,6 @@
- # [source,ruby]
- # ----
- # worker_id, pipe = env
- # Ractor.new(worker_id, pipe) do |worker_id, pipe|
- # end
- # ----
+ # [source,ruby]
+ # ----
+ # worker_id, pipe = env
+ # Ractor.new(worker_id, pipe) do |worker_id, pipe|
+ # end
+ # ----
@@ -25 +24,0 @@
- #
@@ -34,2 +32,0 @@
- # @example
- #
@@ -37 +33,0 @@
- #
lib/rubocop/cop/lint/unified_integer.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/unified_integer.rb 2024-08-02 02:49:21.007682355 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/unified_integer.rb 2024-08-02 02:49:21.279683845 +0000
@@ -11 +10,0 @@
- #
@@ -15,2 +13,0 @@
- # @example
- #
@@ -18 +14,0 @@
- #
lib/rubocop/cop/lint/unreachable_code.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/unreachable_code.rb 2024-08-02 02:49:21.007682355 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/unreachable_code.rb 2024-08-02 02:49:21.279683845 +0000
@@ -13 +12,0 @@
- #
@@ -20 +18,0 @@
- #
@@ -30,2 +27,0 @@
- # @example
- #
@@ -33 +28,0 @@
- #
lib/rubocop/cop/lint/useless_assignment.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/useless_assignment.rb 2024-08-02 02:49:21.007682355 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/useless_assignment.rb 2024-08-02 02:49:21.279683845 +0000
@@ -31 +30,0 @@
- #
@@ -37,2 +35,0 @@
- # @example
- #
@@ -40 +36,0 @@
- #
@@ -64 +60 @@
- variable.assignments.each do |assignment|
+ variable.assignments.reverse_each do |assignment|
lib/rubocop/cop/lint/useless_else_without_rescue.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/useless_else_without_rescue.rb 2024-08-02 02:49:21.007682355 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/useless_else_without_rescue.rb 2024-08-02 02:49:21.279683845 +0000
@@ -13 +12,0 @@
- #
@@ -20,2 +18,0 @@
- # @example
- #
@@ -23 +19,0 @@
- #
lib/rubocop/cop/lint/useless_setter_call.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/lint/useless_setter_call.rb 2024-08-02 02:49:21.007682355 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/lint/useless_setter_call.rb 2024-08-02 02:49:21.283683867 +0000
@@ -20 +19,0 @@
- #
@@ -26,2 +24,0 @@
- # @example
- #
@@ -29 +25,0 @@
- #
lib/rubocop/cop/naming/predicate_name.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/naming/predicate_name.rb 2024-08-02 02:49:21.075682727 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/naming/predicate_name.rb 2024-08-02 02:49:21.295683933 +0000
@@ -6 +6 @@
- # Checks that predicate methods names end with a question mark and
+ # Checks that predicate method names end with a question mark and
@@ -9,21 +9,10 @@
- # A method is determined to be a predicate method if its name starts
- # with one of the prefixes defined in the `NamePrefix` configuration.
- # You can change what prefixes are considered by changing this option.
- # Any method name that starts with one of these prefixes is required by
- # the cop to end with a `?`. Other methods can be allowed by adding to
- # the `AllowedMethods` configuration.
- #
- # NOTE: The `is_a?` method is allowed by default.
- #
- # If `ForbiddenPrefixes` is set, methods that start with the configured
- # prefixes will not be allowed and will be removed by autocorrection.
- #
- # In other words, if `ForbiddenPrefixes` is empty, a method named `is_foo`
- # will register an offense only due to the lack of question mark (and will be
- # autocorrected to `is_foo?`). If `ForbiddenPrefixes` contains `is_`,
- # `is_foo` will register an offense both because the ? is missing and because of
- # the `is_` prefix, and will be corrected to `foo?`.
- #
- # NOTE: `ForbiddenPrefixes` is only applied to prefixes in `NamePrefix`;
- # a prefix in the former but not the latter will not be considered by
- # this cop.
+ # A method is determined to be a predicate method if its name starts with
+ # one of the prefixes listed in the `NamePrefix` configuration. The list
+ # defaults to `is_`, `has_`, and `have_` but may be overridden.
+ #
+ # Predicate methods must end with a question mark.
+ #
+ # When `ForbiddenPrefixes` is also set (as it is by default), predicate
+ # methods which begin with a forbidden prefix are not allowed, even if
+ # they end with a `?`. These methods should be changed to remove the
+ # prefix.
@@ -31 +20 @@
- # @example
+ # @example NamePrefix: ['is_', 'has_', 'have_'] (default)
@@ -36 +25,3 @@
- # def is_even?(value)
+ # # When ForbiddenPrefixes: ['is_', 'has_', 'have_'] (default)
+ # # good
+ # def even?(value)
@@ -38,0 +30 @@
+ # # When ForbiddenPrefixes: []
@@ -40 +32 @@
- # def even?(value)
+ # def is_even?(value)
@@ -42,0 +35 @@
+ # @example NamePrefix: ['seems_to_be_']
@@ -44 +37 @@
- # def has_value
+ # def seems_to_be_even(value)
@@ -47 +40,3 @@
- # def has_value?
+ # # When ForbiddenPrefixes: ['seems_to_be_']
+ # # good
+ # def even?(value)
@@ -49,0 +45 @@
+ # # When ForbiddenPrefixes: []
@@ -51 +47 @@
- # def value?
+ # def seems_to_be_even?(value)
@@ -54,0 +51 @@
+ # # Despite starting with the `is_` prefix, this method is allowed
@@ -58,0 +56,19 @@
+ # @example AllowedMethods: ['is_even?']
+ # # good
+ # def is_even?(value)
+ # end
+ #
+ # @example MethodDefinitionMacros: ['define_method', 'define_singleton_method'] (default)
+ # # bad
+ # define_method(:is_even) { |value| }
+ #
+ # # good
+ # define_method(:even?) { |value| }
+ #
+ # @example MethodDefinitionMacros: ['def_node_matcher']
+ # # bad
+ # def_node_matcher(:is_even) { |value| }
+ #
+ # # good
+ # # def_node_matcher(:even?) { |value| }
+ #
@@ -94,0 +111,10 @@
+
+ def validate_config
+ forbidden_prefixes.each do |forbidden_prefix|
+ next if predicate_prefixes.include?(forbidden_prefix)
+
+ raise ValidationError, <<~MSG.chomp
+ The `Naming/PredicateName` cop is misconfigured. Prefix #{forbidden_prefix} must be included in NamePrefix because it is included in ForbiddenPrefixes.
+ MSG
+ end
+ end
lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb 2024-08-02 02:49:21.075682727 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb 2024-08-02 02:49:21.295683933 +0000
@@ -115,0 +116 @@
+ # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
@@ -122 +123,8 @@
- corrector.replace(child_node, preferred_name) if child_node.lvar_type?
+ if child_node.lvar_type?
+ parent_node = child_node.parent
+ if parent_node.respond_to?(:value_omission?) && parent_node.value_omission?
+ corrector.insert_after(parent_node.loc.operator, " #{preferred_name}")
+ else
+ corrector.replace(child_node, preferred_name)
+ end
+ end
@@ -129,0 +138 @@
+ # rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
lib/rubocop/cop/style/def_with_parentheses.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/def_with_parentheses.rb 2024-08-02 02:49:21.083682771 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/def_with_parentheses.rb 2024-08-02 02:49:21.303683977 +0000
@@ -31,2 +30,0 @@
- # @example
- #
lib/rubocop/cop/style/each_for_simple_loop.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/each_for_simple_loop.rb 2024-08-02 02:49:21.083682771 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/each_for_simple_loop.rb 2024-08-02 02:49:21.307683999 +0000
@@ -19 +18,0 @@
- # @example
lib/rubocop/cop/style/eval_with_location.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/eval_with_location.rb 2024-08-02 02:49:21.087682793 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/eval_with_location.rb 2024-08-02 02:49:21.307683999 +0000
@@ -19,0 +20,12 @@
+ # NOTE: This cop works only when a string literal is given as a code string.
+ # No offense is reported if a string variable is given as below:
+ #
+ # [source,ruby]
+ # ----
+ # code = <<-RUBY
+ # def do_something
+ # end
+ # RUBY
+ # eval code # not checked.
+ # ----
+ #
@@ -44,11 +55,0 @@
- #
- # This cop works only when a string literal is given as a code string.
- # No offense is reported if a string variable is given as below:
- #
- # @example
- # # not checked
- # code = <<-RUBY
- # def do_something
- # end
- # RUBY
- # eval code
lib/rubocop/cop/style/file_read.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/file_read.rb 2024-08-02 02:49:21.087682793 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/file_read.rb 2024-08-02 02:49:21.307683999 +0000
@@ -9,2 +9 @@
- # ## text mode
- # # bad
+ # # bad - text mode
@@ -26,3 +25 @@
- # @example
- # ## binary mode
- # # bad
+ # # bad - binary mode
lib/rubocop/cop/style/file_write.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/file_write.rb 2024-08-02 02:49:21.087682793 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/file_write.rb 2024-08-02 02:49:21.307683999 +0000
@@ -20,2 +20 @@
- # ## text mode
- # # bad
+ # # bad - text mode
@@ -30,3 +29 @@
- # @example
- # ## binary mode
- # # bad
+ # # bad - binary mode
lib/rubocop/cop/style/global_std_stream.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/global_std_stream.rb 2024-08-02 02:49:21.087682793 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/global_std_stream.rb 2024-08-02 02:49:21.311684021 +0000
@@ -47 +47,3 @@
- const_name = node.children[1]
+ return if namespaced?(node)
+
+ const_name = node.short_name
@@ -61,0 +64,4 @@
+ end
+
+ def namespaced?(node)
+ !node.namespace.nil? && (node.relative? || !node.namespace.cbase_type?)
lib/rubocop/cop/style/if_with_boolean_literal_branches.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb 2024-08-02 02:49:21.091682815 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb 2024-08-02 02:49:21.311684021 +0000
@@ -47 +46,0 @@
- # @example
lib/rubocop/cop/style/invertible_unless_condition.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/invertible_unless_condition.rb 2024-08-02 02:49:21.091682815 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/invertible_unless_condition.rb 2024-08-02 02:49:21.311684021 +0000
@@ -75,2 +75,2 @@
- def invertible?(node)
- case node.type
+ def invertible?(node) # rubocop:disable Metrics/CyclomaticComplexity
+ case node&.type
lib/rubocop/cop/style/method_call_with_args_parentheses.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/method_call_with_args_parentheses.rb 2024-08-02 02:49:21.095682837 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/method_call_with_args_parentheses.rb 2024-08-02 02:49:21.315684043 +0000
@@ -7 +7 @@
- # method calls containing parameters.
+ # method calls containing arguments.
lib/rubocop/cop/style/missing_else.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/missing_else.rb 2024-08-02 02:49:21.095682837 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/missing_else.rb 2024-08-02 02:49:21.315684043 +0000
@@ -171,4 +170,0 @@
- def empty_else_cop_enabled?
- empty_else_config.fetch('Enabled')
- end
-
lib/rubocop/cop/style/multiline_when_then.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/multiline_when_then.rb 2024-08-02 02:49:21.095682837 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/multiline_when_then.rb 2024-08-02 02:49:21.315684043 +0000
@@ -57,4 +56,0 @@
-
- def accept_node_type?(node)
- node&.array_type? || node&.hash_type?
- end
lib/rubocop/cop/style/redundant_condition.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/redundant_condition.rb 2024-08-02 02:49:21.103682881 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/redundant_condition.rb 2024-08-02 02:49:21.323684086 +0000
@@ -15 +14,0 @@
- # @example
lib/rubocop/cop/style/redundant_regexp_escape.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/redundant_regexp_escape.rb 2024-08-02 02:49:21.107682903 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/redundant_regexp_escape.rb 2024-08-02 02:49:21.327684108 +0000
@@ -98,4 +98,3 @@
- if Gem::Version.new(Regexp::Parser::VERSION) >= Gem::Version.new('2.0')
- def each_escape(node)
- node.parsed_tree&.traverse&.reduce(0) do |char_class_depth, (event, expr)|
- yield(expr.text[1], expr.ts, !char_class_depth.zero?) if expr.type == :escape
+ def each_escape(node)
+ node.parsed_tree&.traverse&.reduce(0) do |char_class_depth, (event, expr)|
+ yield(expr.text[1], expr.ts, !char_class_depth.zero?) if expr.type == :escape
@@ -103,19 +102,4 @@
- if expr.type == :set
- char_class_depth + (event == :enter ? 1 : -1)
- else
- char_class_depth
- end
- end
- end
- # Please remove this `else` branch when support for regexp_parser 1.8 will be dropped.
- # It's for compatibility with regexp_parser 1.8 and will never be maintained.
- else
- def each_escape(node)
- node.parsed_tree&.traverse&.reduce(0) do |char_class_depth, (event, expr)|
- yield(expr.text[1], expr.start_index, !char_class_depth.zero?) if expr.type == :escape
-
- if expr.type == :set
- char_class_depth + (event == :enter ? 1 : -1)
- else
- char_class_depth
- end
+ if expr.type == :set
+ char_class_depth + (event == :enter ? 1 : -1)
+ else
+ char_class_depth
lib/rubocop/cop/style/sole_nested_conditional.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/sole_nested_conditional.rb 2024-08-02 02:49:21.111682925 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/sole_nested_conditional.rb 2024-08-02 02:49:21.331684130 +0000
@@ -162 +162,7 @@
- corrector.wrap(condition, '(', ')')
+ if condition.call_type?
+ source = parenthesized_method_arguments(condition)
+
+ corrector.replace(condition, source)
+ else
+ corrector.wrap(condition, '(', ')')
+ end
@@ -239 +245,14 @@
- wrap_condition?(condition) ? "(#{condition.source})" : condition.source
+ return condition.source unless wrap_condition?(condition)
+
+ if condition.call_type?
+ parenthesized_method_arguments(condition)
+ else
+ "(#{condition.source})"
+ end
+ end
+
+ def parenthesized_method_arguments(node)
+ method_call = node.source_range.begin.join(node.loc.selector.end).source
+ arguments = node.first_argument.source_range.begin.join(node.source_range.end).source
+
+ "#{method_call}(#{arguments})"
lib/rubocop/cop/style/while_until_do.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/while_until_do.rb 2024-08-02 02:49:21.115682947 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/while_until_do.rb 2024-08-02 02:49:21.335684152 +0000
@@ -20,2 +19,0 @@
- # @example
- #
lib/rubocop/cop/style/while_until_modifier.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/while_until_modifier.rb 2024-08-02 02:49:21.115682947 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/while_until_modifier.rb 2024-08-02 02:49:21.335684152 +0000
@@ -19 +18,0 @@
- # @example
lib/rubocop/cop/style/zero_length_predicate.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/style/zero_length_predicate.rb 2024-08-02 02:49:21.115682947 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/style/zero_length_predicate.rb 2024-08-02 02:49:21.339684174 +0000
@@ -50 +50,5 @@
- alias on_csend on_send
+
+ def on_csend(node)
+ check_zero_length_predicate(node)
+ check_zero_length_comparison(node)
+ end
lib/rubocop/cop/variable_force.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/cop/variable_force.rb 2024-08-02 02:49:21.115682947 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/cop/variable_force.rb 2024-08-02 02:49:21.339684174 +0000
@@ -30 +30,4 @@
- VARIABLE_ASSIGNMENT_TYPES = [VARIABLE_ASSIGNMENT_TYPE, REGEXP_NAMED_CAPTURE_TYPE].freeze
+ PATTERN_MATCH_VARIABLE_TYPE = :match_var
+ VARIABLE_ASSIGNMENT_TYPES = [
+ VARIABLE_ASSIGNMENT_TYPE, REGEXP_NAMED_CAPTURE_TYPE, PATTERN_MATCH_VARIABLE_TYPE
+ ].freeze
@@ -114,0 +118 @@
+ [PATTERN_MATCH_VARIABLE_TYPE, :process_pattern_match_variable],
@@ -173,0 +178,8 @@
+
+ skip_children!
+ end
+
+ def process_pattern_match_variable(node)
+ name = node.children.first
+
+ variable_table.declare_variable(name, node) unless variable_table.variable_exist?(name)
lib/rubocop/core_ext/string.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/core_ext/string.rb 2024-08-02 02:49:21.119682969 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/core_ext/string.rb 2024-08-02 02:49:21.339684174 +0000
@@ -12,6 +12,2 @@
- # ''.blank? #=> true
- #
- # @example
- # ' '.blank? #=> true
- #
- # @example
+ # ''.blank? #=> true
+ # ' '.blank? #=> true
lib/rubocop/ext/regexp_node.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/ext/regexp_node.rb 2024-08-02 02:49:21.119682969 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/ext/regexp_node.rb 2024-08-02 02:49:21.339684174 +0000
@@ -18,3 +18,2 @@
- if Gem::Version.new(Regexp::Parser::VERSION) >= Gem::Version.new('2.0')
- def assign_properties(*)
- super
+ def assign_properties(*)
+ super
@@ -22,28 +21,5 @@
- str = with_interpolations_blanked
- @parsed_tree = begin
- Regexp::Parser.parse(str, options: options)
- rescue StandardError
- nil
- end
- origin = loc.begin.end
- @parsed_tree&.each_expression(true) { |e| e.origin = origin }
- end
- # Please remove this `else` branch when support for regexp_parser 1.8 will be dropped.
- # It's for compatibility with regexp_parser 1.8 and will never be maintained.
- else
- def assign_properties(*)
- super
-
- str = with_interpolations_blanked
- begin
- @parsed_tree = Regexp::Parser.parse(str, options: options)
- rescue StandardError
- @parsed_tree = nil
- else
- origin = loc.begin.end
- source = @parsed_tree.to_s
- @parsed_tree.each_expression(true) do |e|
- e.origin = origin
- e.source = source
- end
- end
+ str = with_interpolations_blanked
+ @parsed_tree = begin
+ Regexp::Parser.parse(str, options: options)
+ rescue StandardError
+ nil
@@ -50,0 +27,2 @@
+ origin = loc.begin.end
+ @parsed_tree&.each_expression(true) { |e| e.origin = origin }
lib/rubocop/options.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/options.rb 2024-08-02 02:49:21.123682991 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/options.rb 2024-08-02 02:49:21.347684218 +0000
@@ -618 +618,3 @@
- 'parallel. Default is true.'],
+ 'parallel. Default is true.',
+ 'You can specify the number of parallel processes using',
+ 'the $PARALLEL_PROCESSOR_COUNT environment variable.'],
lib/rubocop/version.rb
--- /tmp/d20240802-2947-y383cb/rubocop-1.65.0/lib/rubocop/version.rb 2024-08-02 02:49:21.131683035 +0000
+++ /tmp/d20240802-2947-y383cb/rubocop-1.65.1/lib/rubocop/version.rb 2024-08-02 02:49:21.351684240 +0000
@@ -6 +6 @@
- STRING = '1.65.0'
+ STRING = '1.65.1'
|
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.65.1
branch
2 times, most recently
from
43cdcae
to
9aa5ad7
Compare
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.65.0 to 1.65.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.65.0...v1.65.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.65.1
branch
from
9aa5ad7
to
a5816b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.65.0 to 1.65.1.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
b073d7aCut 1.65.18c4c144Update Changelog19b3d9dMerge pull request #13083 from Earlopain/false-positive-global-std-stream761b917Fix false positive forStyle/GlobalStdStreamfor namespaced constants58eeb7aClarify docs in Naming/PredicateName2443641Add a validate_config for Naming/PredicateName68bd9daMerge pull request #13079 from koic/fix_incorrect_autocorrect_for_naming_resc...748a568Merge pull request #13081 from fatkodima/zero_length_predicate-false-positive70d8e88Fix a false positive forStyle/ZeroLengthPredicatewhen using safe navigati...ea309c2[Fix #13076] Fix an incorrect autocorrect for `Naming/RescuedExceptionsVariab...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)