clean up record logic #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgioioso
commented
Sep 18, 2023
| @@ -137,7 +137,7 @@ struct LogEntry { | |||
| LogEntry* next; // The next LogEntry pointer | |||
|
|
|||
| std::string result; // The execution result of the LogEntry | |||
| char status; // | |||
| char status; // TODO(Katie): does this need to be thread safe? | |||
There was a problem hiding this comment.
@Steamgjk Does this need to be an atomic type? It seems like recordTd could be reading this value while processTd is writing it.
|
@Steamgjk this is the first logic change I have made. I believe this change does not affect correctness, but I may be missing some nuances of the codebase. Can you please double check my logic? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the record logic.
Previously, when a duplicate request is received (either because the client retries the request or the replica receives a missed index), the duplicate entry is added to
ProcessQueue. The duplicate entry is then handled depending on the status of the entry.In this PR, if a duplicate request is received,
recordTdchecks the status of the entry. IfPROCESSED, the entry is routed tofastReplyQuso the reply can be resent. If not processed, the other request is still being processed, andrecordTddoes nothing with the new request.This significantly simplifies the logic of
processTdbecause nowprocessTdonly handles entries with statusINITIAL.