feat: persisted operations #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoviDeCroock
force-pushed
the
trusted-documents
branch
from
76a0416
to
fc3b39b
Compare
JoviDeCroock
force-pushed
the
trusted-documents
branch
from
7b461fc
to
5464c19
Compare
JoviDeCroock
force-pushed
the
trusted-documents
branch
from
5464c19
to
ba300e3
Compare
JoviDeCroock
commented
Dec 8, 2023
| url: | ||
| process.env.NODE_ENV === 'production' | ||
| ? 'https://spacex-fuse.vercel.app/api/fuse' | ||
| : 'http://localhost:3000/api/fuse', | ||
| exchanges: [cacheExchange, ssr, persistedExchange, fetchExchange], |
There was a problem hiding this comment.
We should add this as an option rather than having folks specify exchanges I reckon
|
Closing this for the time being but I do want to work this out eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35
This adds a way to adopting
persisted-operationswithinfuse, this leverages an exchange to take the pre-computeddocumentIdfrom thedocumentand sends it for mutations/queries. When we see queries the exchange will cast this to aGEToperations to improve browser cache-ability of operations.This is focussed currently on the Next.js way where we have our
datalayerco-located with our front-end. This does not facilitate mobile/... clients yet, to do so we might need to expand the options of ourroute-handlerto fetch persisted hashes from aKey-valuestore. We could facilitate pushing to i.e. Redis/... in a CLI and then configure our GraphQL endpoint to pull from there when a hash comes in.Something that I would still like to improve here is the fact that you need to manually pass in the
.jsonfile. I was thinking that this could maybe be a fairly automatic adoption journey where you are opted into this automatically and need to opt-out explicitly.Would be eager to hear peoples thoughts here
Personally I gravitate towards supporting a K/V store like Redis, ... or the JSON file for the simple case where we only have i.e. a co-located Next.JS application 😅 added an example how it could look like with
vercel/kv