Make module loading compatible with requirejs when used with electron. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just switches the order of module loading scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just switches the order of module loading scenarios.
This change only has an effect on apps that are build with electron or nw.js in combination with the require.js optimizer. The problem with these apps is that they share the "require" statement of node.js with the front end, which then collides with the "require" statement of require.js.
Although it is possible to define a different namespace during r.js optimization, knockout and ko-projections will throw some funny errors.
This is only way I got it to work, combined with some other hacky stuff.
I fell in love with your yeoman generator for knockout and really don't want to switch to angular or any other hyped framework to be able to build electron/hybrid apps.