Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of Ghostscript to use qpdf and tesseract directly #2338

Merged
merged 11 commits into from
Nov 26, 2024
Merged

Removal of Ghostscript to use qpdf and tesseract directly #2338

merged 11 commits into from
Nov 26, 2024

Conversation

Frooodle
Copy link
Member

Description

Please provide a summary of the changes, including relevant motivation and context.

Closes #(issue_number)

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 26, 2024
@github-actions github-actions bot added Documentation Improvements or additions to documentation Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Back End Issues related to back-end development Docker Pull requests that update Docker code Translation API API-related issues or pull requests Test Testing-related issues or pull requests labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

🚀 Translation Verification Summary

🔄 Reference Branch: pr-branch

📃 File Check: messages_ar_AR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ar_AR.properties.

📃 File Check: messages_az_AZ.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_az_AZ.properties.

📃 File Check: messages_bg_BG.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_bg_BG.properties.

📃 File Check: messages_ca_CA.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ca_CA.properties.

📃 File Check: messages_cs_CZ.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_cs_CZ.properties.

📃 File Check: messages_da_DK.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_da_DK.properties.

📃 File Check: messages_de_DE.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_de_DE.properties.

📃 File Check: messages_el_GR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_el_GR.properties.

📃 File Check: messages_en_US.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_en_US.properties.

📃 File Check: messages_es_ES.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_es_ES.properties.

📃 File Check: messages_eu_ES.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_eu_ES.properties.

📃 File Check: messages_fr_FR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_fr_FR.properties.

📃 File Check: messages_ga_IE.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ga_IE.properties.

📃 File Check: messages_hi_IN.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_hi_IN.properties.

📃 File Check: messages_hr_HR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_hr_HR.properties.

📃 File Check: messages_hu_HU.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_hu_HU.properties.

📃 File Check: messages_id_ID.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_id_ID.properties.

📃 File Check: messages_it_IT.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_it_IT.properties.

📃 File Check: messages_ja_JP.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ja_JP.properties.

📃 File Check: messages_ko_KR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ko_KR.properties.

📃 File Check: messages_nl_NL.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_nl_NL.properties.

📃 File Check: messages_no_NB.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_no_NB.properties.

📃 File Check: messages_pl_PL.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_pl_PL.properties.

📃 File Check: messages_pt_BR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_pt_BR.properties.

📃 File Check: messages_pt_PT.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_pt_PT.properties.

📃 File Check: messages_ro_RO.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ro_RO.properties.

📃 File Check: messages_ru_RU.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_ru_RU.properties.

📃 File Check: messages_sk_SK.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_sk_SK.properties.

📃 File Check: messages_sr_LATN_RS.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_sr_LATN_RS.properties.

📃 File Check: messages_sv_SE.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_sv_SE.properties.

📃 File Check: messages_th_TH.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_th_TH.properties.

📃 File Check: messages_tr_TR.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_tr_TR.properties.

📃 File Check: messages_uk_UA.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_uk_UA.properties.

📃 File Check: messages_vi_VN.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_vi_VN.properties.

📃 File Check: messages_zh_CN.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_zh_CN.properties.

📃 File Check: messages_zh_TW.properties

  1. Test Status: ❌ Failed
  • Issue:
    • Mismatched line count: 1270 (reference) vs 1262 (current). Comments, empty lines, or translation strings are missing.
  1. Test Status: ❌ Failed
  • Issue:
    • Missing keys in messages_en_GB.properties: releases.header, releases.footer, releases.note, releases.title, releases.current.version that are not present in messages_zh_TW.properties.

❌ Overall Check Status: Failed

@Frooodle please check your translation if it conforms to the standard. Follow the format of messages_en_GB.properties

@pixeebot pixeebot bot mentioned this pull request Nov 26, 2024
Merged
@pixeebot
Hardening suggestions for Stirling-PDF / ghostscript (#2339)
5a67b0c 
* Protect `readLine()` against DoS

* Sanitized user-provided file names in HTTP multipart uploads

---------

Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com>
@pixeebot pixeebot bot mentioned this pull request Nov 26, 2024
Closed
@Frooodle Frooodle merged commit 833b3c4 into main Nov 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API API-related issues or pull requests Back End Issues related to back-end development Docker Pull requests that update Docker code Documentation Improvements or additions to documentation Front End Issues or pull requests related to front-end development Java Pull requests that update Java code size:XXL This PR changes 1000+ lines, ignoring generated files. Test Testing-related issues or pull requests Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Frooodle