Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for Telegram & Twitter #10

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix validation for Telegram & Twitter #10

merged 2 commits into from
Dec 10, 2024

Conversation

srph
Copy link
Contributor

@srph srph commented Dec 10, 2024

Allow TG/Twitter to be nullable if the Agent doesn't support it.

I decided to do this for schema consistency. The alternative is to allow the fields to be completely optional - which means the properties won't show up in the endpoint at all.

Waiting for a PR in the frontend to merge first.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
echo-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 8:28am

@srph srph requested a review from brianbodollo December 10, 2024 08:26
@srph srph merged commit 384cfee into main Dec 10, 2024
3 checks passed
@srph srph deleted the kier/fix-validation branch December 10, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants