Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The only ICA we submit that times-out at the day epoch is the undelegation ICA. However, in practice, it acts as if it times out at the stride epoch.
The reason for this is delegation ICAs are submitted immediately after the undelegation ICA (timing out at the end of the stride epoch), so if an undelegation ICA was not relayed by then, the delegation ICA would time out and close the channel.
Considering this, it makes more sense to keep our epochly time out's consistent.
This PR updates the undelegation ICA to timeout at the stride epoch, and removes the day epoch function.
I'd recommend reviewing commit by commit
Brief Changelog
SubmitTxsDayEpoch
SubmitTxsEpoch
andSubmitTxsStrideEpoch
SubmitTxs
toSubmitICATx
SubmitTxsStrideEpoch
toSubmitICATxStrideEpoch