Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed submitTxsDayEpoch #1272

Closed
wants to merge 8 commits into from
Closed

removed submitTxsDayEpoch #1272

wants to merge 8 commits into from

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Aug 27, 2024

Context

The only ICA we submit that times-out at the day epoch is the undelegation ICA. However, in practice, it acts as if it times out at the stride epoch.

The reason for this is delegation ICAs are submitted immediately after the undelegation ICA (timing out at the end of the stride epoch), so if an undelegation ICA was not relayed by then, the delegation ICA would time out and close the channel.

Considering this, it makes more sense to keep our epochly time out's consistent.

This PR updates the undelegation ICA to timeout at the stride epoch, and removes the day epoch function.

I'd recommend reviewing commit by commit

Brief Changelog

  • Updated undelegation ICA to timeout at the stride epoch
  • Removed SubmitTxsDayEpoch
  • Combined SubmitTxsEpoch and SubmitTxsStrideEpoch
  • Renamed SubmitTxs to SubmitICATx
  • Renamed SubmitTxsStrideEpoch to SubmitICATxStrideEpoch
  • Fixed error messages during submission

@sampocs
Copy link
Collaborator Author

sampocs commented Aug 28, 2024

I actually don't think this works cause the day epoch triggers before the stride epoch. So i think when looking up the stride epoch for the timeout, it will grab the wrong one.

To solve it, we'd have to submit this on the stride epoch. Closing this for now as this change isn't strictly necessary and it seems a bit risky to try to fix it at this point.

--

In the future, I think we should just remove the day epoch entirely, and just do everything on the same epoch off intervals (e.g. unbond at stride epoch % 4). Would make it a lot easier to test too since we could trigger both delegations and unbondings on the same epoch (instead of having to stagger them)

cc @riley-stride

@sampocs sampocs closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant