feat(internal): Base controller - Merge event dispatch options with d…

…efaults. Make it easier to dispatch events with detail.target, bubbles, and cancellable while specifying other options

dist/auto_submit_form_controller.d.ts

@@ -1,6 +1,6 @@
 import { BaseController } from "./base_controller";
 export declare class AutoSubmitFormController extends BaseController {
-    private boundHandler;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
     private handler;

dist/autosize_controller.d.ts

@@ -1,9 +1,9 @@
 import { BaseController } from "./base_controller";
 export declare class AutosizeController extends BaseController {
-    private boundHandler;
+    initialize(): void;
     connect(): void;
     windowResize(): void;
-    private handler;
+    private _handler;
     private autosize;
 }
 //# sourceMappingURL=autosize_controller.d.ts.map

dist/char_count_controller.d.ts

@@ -14,10 +14,10 @@ export declare class CharCountController extends BaseController {
     hasMaxValue: boolean;
     errorClass: string;
     hasErrorClass: boolean;
-    boundHandler: () => void;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
-    updateCharCount(): void;
-    isValidCount(count: number): boolean;
+    private _updateCharCount;
+    private _isValidCount;
 }
 //# sourceMappingURL=char_count_controller.d.ts.map

dist/detect_dirty_controller.d.ts

@@ -1,11 +1,11 @@
 import { BaseController } from "./base_controller";
 export declare class DetectDirtyController extends BaseController {
     initialValue: string | boolean | null;
-    boundHandler: (event?: Event | undefined) => void;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
     restore(): void;
-    private handler;
+    private checkDirty;
 }
 export declare function isDirty(element: HTMLElement): boolean;
 //# sourceMappingURL=detect_dirty_controller.d.ts.map

dist/limited_selection_checkboxes_controller.d.ts

@@ -10,8 +10,7 @@ export declare class LimitedSelectionCheckboxesController extends BaseController
     readonly inputTargets: HTMLInputElement[];
     readonly maxValue: number;
     readonly messageValue: string;
-    maxSelections: number;
-    boundHandleInputs: (event: Event) => void;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
     handleInputs(event: Event): void;

dist/password_confirm_controller.d.ts

@@ -5,7 +5,7 @@ export declare class PasswordConfirmController extends BaseController {
     readonly passwordTargets: HTMLInputElement[];
     readonly errorClass: string;
     readonly hasErrorClass: boolean;
-    private boundCheckPasswordsMatch;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
     private allPasswordsMatch;

dist/responsive_iframe_controller.d.ts

@@ -5,7 +5,7 @@ interface ResponsiveIframeMessage {
     height: number;
 }
 export declare class ResponsiveIframeWrapperController extends BaseController {
-    boundMessageReceived: (message: MessageEvent<ResponsiveIframeMessage>) => void;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
     messageReceived(message: MessageEvent<ResponsiveIframeMessage>): void;

dist/utilities/elements.d.ts

@@ -1,8 +1,8 @@
-export declare function isHTMLLinkElement(element: Element): element is HTMLLinkElement;
-export declare function isHTMLFormElement(element: Element): element is HTMLFormElement;
-export declare function isHTMLInputElement(element: Element): element is HTMLInputElement;
-export declare function isHTMLImageElement(element: Element): element is HTMLImageElement;
-export declare function isElementCheckable(element: Element): element is HTMLInputElement & {
-    checked: boolean;
-};
+export declare function isHTMLLinkElement(element: Element): element is HTMLLinkElement;
+export declare function isHTMLFormElement(element: Element): element is HTMLFormElement;
+export declare function isHTMLInputElement(element: Element): element is HTMLInputElement;
+export declare function isHTMLImageElement(element: Element): element is HTMLImageElement;
+export declare function isElementCheckable(element: Element): element is HTMLInputElement & {
+    checked: boolean;
+};
 //# sourceMappingURL=elements.d.ts.map

dist/word_count_controller.d.ts

@@ -14,7 +14,7 @@ export declare class WordCountController extends BaseController {
     hasMaxValue: boolean;
     errorClass: string;
     hasErrorClass: boolean;
-    boundHandler: () => void;
+    initialize(): void;
     connect(): void;
     disconnect(): void;
     updateWordCount(): void;

src/base_controller.ts

@@ -27,8 +27,12 @@ export class BaseController extends Controller {
     });
   }
 
-  dispatch(element: HTMLElement, eventName: string, options: CustomEventInit = {bubbles: true, cancelable: true, detail: {target: element}}) {
-    let event = new CustomEvent(eventName, options);
+  dispatch(element: HTMLElement, eventName: string, options: CustomEventInit = {}) {
+    let mergedOptions = Object.assign({}, {bubbles: true, cancelable: true, detail: {target: element}}, options);
+    if (!!mergedOptions.detail.target) {
+      mergedOptions.detail.target = element;
+    }
+    let event = new CustomEvent(eventName, mergedOptions);
     element.dispatchEvent(event);
   }