Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: First rough cut at PFS SETUPFIELD/GETOBJECT abstract commands #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: First rough cut at PFS SETUPFIELD/GETOBJECT abstract commands #5

wants to merge 1 commit into from
+126 −0

Conversation

ejeschke
Copy link

Based on basic transliteration of @CraigLoomis's pseudo-code

WIP: DO NOT MERGE

CraigLoomis
CraigLoomis reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@CraigLoomis CraigLoomis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks appealingly straightforward, and good to me.

Noted that we will need to iterate on how best to start guiding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CraigLoomis CraigLoomis CraigLoomis left review comments

@RobertLuptonTheGood RobertLuptonTheGood Awaiting requested review from RobertLuptonTheGood

@yukimoritani yukimoritani Awaiting requested review from yukimoritani

@naoyukitamura naoyukitamura Awaiting requested review from naoyukitamura

@koshida-naoj koshida-naoj Awaiting requested review from koshida-naoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejeschke @CraigLoomis