Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
sumo-drosiek authored Jun 28, 2024
1 parent 42de8ac commit ff5c199
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ filelog/containers:
output: strip-trailing-newline
source_identifier: attributes["log.file.path"]
type: recombine
## Ensure we are combine everything up to `is_last_entry` even on the file beginning
## Ensure we combine everything up to `is_last_entry` even on the file beginning
max_unmatched_batch_size: 0

## merge-cri-lines stitches back together log lines split by CRI logging drivers.
Expand All @@ -114,7 +114,7 @@ filelog/containers:
overwrite_with: newest
source_identifier: attributes["log.file.path"]
type: recombine
## Ensure we are combine everything up to `is_last_entry` even on the file beginning
## Ensure we combine everything up to `is_last_entry` even on the file beginning
max_unmatched_batch_size: 0

## strip-trailing-newline removes the trailing "\n" from the `log` key. This is required for logs coming from Docker container runtime.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ processors:
overwrite_with: newest
source_identifier: resource["cloudwatch.log.stream"]
type: recombine
## Ensure we are combine everything up to `is_last_entry` even on the file beginning
## Ensure we combine everything up to `is_last_entry` even on the file beginning
max_unmatched_batch_size: 0
- id: merge-multiline-logs
combine_field: attributes.log
Expand Down

0 comments on commit ff5c199

Please sign in to comment.