Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prometheus from images in documentation #3261

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Remove prometheus from images in documentation #3261

merged 2 commits into from
Sep 13, 2023

Conversation

dmolenda-sumo
Copy link
Contributor

No description provided.

@dmolenda-sumo dmolenda-sumo requested a review from a team as a code owner September 13, 2023 07:09
@github-actions github-actions bot added the documentation documentation label Sep 13, 2023
swiatekm
swiatekm reviewed Sep 13, 2023
View reviewed changes
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component replacing Prometheus should be called "Metrics Collector" instead of "Metadata enrichment" and we should indicate somehow that it's using the Prometheus pull model.

@swiatekm swiatekm added this to the v4.0 milestone Sep 13, 2023
@dmolenda-sumo dmolenda-sumo merged commit 0da8322 into main Sep 13, 2023
@dmolenda-sumo dmolenda-sumo deleted the update-images-in-docs-for-v4 branch September 13, 2023 11:11
@swiatekm swiatekm mentioned this pull request Sep 21, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
documentation documentation skip-changelog
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmolenda-sumo @andrzej-stencel @swiatekm