chore(metrics): route based on job attributes #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
chore/metrics/simplify-routing
branch
2 times, most recently
from
9549204 to
00c127a
Compare
We can do this after having consolidated our remote writes.
swiatekm
force-pushed
the
chore/metrics/simplify-routing
branch
from
00c127a to
374d9e9
Compare
sumo-drosiek
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do this after having consolidated our remote writes.
I've decided to just send the
cloudprovider_*metrics to the kubelet source if it's reported by the kubelet. Never really made sense that we sent it to the controller-manager source. In any case, OTLP source is going to be the default in v4, so this routing setup will only matter for users who manually switch back to the HTTP source.Checklist