Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): drop stale datapoints #3318

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

swiatekm
Copy link

Prometheus and prometheus receiver emit staleness markers in the form of samples with a NaN value whenever a target disappears. These markers aren't that useful when a target is moved between collector Pods, and Sumo currently doesn't handle them correctly.

Drop them in the collector instead.

Checklist

  • Changelog updated or skip changelog label added
  • Template tests added for new features

@swiatekm swiatekm requested a review from a team as a code owner October 12, 2023 14:37
@swiatekm swiatekm force-pushed the fix/metrics/stale-markers branch from 62288be to 6c934b0 Compare October 13, 2023 09:44
@swiatekm swiatekm force-pushed the fix/metrics/stale-markers branch from 6c934b0 to 3ae9032 Compare October 13, 2023 10:05
@swiatekm swiatekm merged commit 70af83f into main Oct 13, 2023
36 checks passed
@swiatekm swiatekm deleted the fix/metrics/stale-markers branch October 13, 2023 11:24
@sumo-backporter
Copy link
Contributor

The backport to release-v3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v3 release-v3
# Navigate to the new working tree
cd .worktrees/backport-release-v3
# Create a new branch
git switch --create backport-3318-to-release-v3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 70af83f69e2b856d4173fdfd3e11739de47b8a43
# Push it to GitHub
git push --set-upstream origin backport-3318-to-release-v3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v3

Then, create a pull request where the base branch is release-v3 and the compare/head branch is backport-3318-to-release-v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants