-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use nix for installing tools in Vagrant #3343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Below is my vagrant.configure section for arm & qemu, which works just fine in this setup :)
|
dbado-sumologic
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ARM and works fine
swiatekm
force-pushed
the
chore/vagrant-nix
branch
from
October 20, 2023 15:42
a2d38f2
to
9f21a37
Compare
swiatekm
force-pushed
the
chore/vagrant-nix
branch
from
October 20, 2023 15:43
9f21a37
to
4df3edc
Compare
swiatekm
force-pushed
the
chore/vagrant-nix
branch
from
October 20, 2023 15:51
4df3edc
to
6355e2b
Compare
sumo-drosiek
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works :)
Co-authored-by: Dominik Rosiek <[email protected]>
sumo-backporter bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
* chore: use nix for installing tools in Vagrant * Add QEMU support for vagrant * Update .gitignore Co-authored-by: Dominik Rosiek <[email protected]> --------- Co-authored-by: Dominik Rosiek <[email protected]> (cherry picked from commit 4b17d85)
swiatekm
added a commit
that referenced
this pull request
Oct 23, 2023
* chore: use nix for installing tools in Vagrant * Add QEMU support for vagrant * Update .gitignore Co-authored-by: Dominik Rosiek <[email protected]> --------- Co-authored-by: Dominik Rosiek <[email protected]> (cherry picked from commit 4b17d85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nix for installing tools in the Vagrant box. This gives us:
You need to do some slight weirdness to force Nix to pull packages during VM provisioning rather than at startup, but otherwise this is fairly straightforward. There's probably a more idiomatic way to do this (install packages from shell.nix into a user environment), but the current way works fine.
Checklist