fix(metrics): use sumologic.metrics.excludeNamespaceRegex instead of sumologic.logs.container.excludeNamespaceRegex
#3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
approved these changes
Dec 6, 2023
…f `sumologic.logs.container.excludeNamespaceRegex`
andrzej-stencel
force-pushed
the
metrics-exclude-namespace-regex
branch
from
3c3c4fc to
2d11eff
Compare
swiatekm
reviewed
Dec 6, 2023
tests/helm/testdata/goldenfile/metadata_metrics_otc/exclude-namespace.output.yaml
Outdated
Show resolved
Hide resolved
swiatekm
approved these changes
Dec 7, 2023
andrzej-stencel
added a commit
that referenced
this pull request
Dec 8, 2023
…f `sumologic.logs.container.excludeNamespaceRegex` Backports #3428
andrzej-stencel
added a commit
that referenced
this pull request
Dec 8, 2023
…f `sumologic.logs.container.excludeNamespaceRegex` Backports #3428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
sumologic.logs.container.excludeNamespaceRegexwas being used to filter out not only container logs, but also metrics. This was incorrect.I have introduced a new property
sumologic.metrics.excludeNamespaceRegexthat can now be used to filter out metrics based on namespaces.