Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add troubleshoot for missing metrics for Argo installation #3493

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

sumo-drosiek
Copy link
Contributor

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner January 11, 2024 09:05
Comment on lines +363 to +367
selectorOverride:
app.kubernetes.io/name: prometheus-node-exporter
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use more than label, because our prometheus-node-expoerter is in version 4.3.1, and bug has been fixed in 4.4.2: prometheus-community/helm-charts#2618

which is used from kube-prometheus-stack in version 42.1.1 (version is 4.4.x) or definitely in 45.3.0

We are using kube-prometheus-stack in version 40.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to #3494

@@ -340,6 +341,31 @@ You [check Prometheus logs](#prometheus-logs) to verify there are no errors duri

You can also check `prometheus_remote_storage_.*` metrics to look for success/failure attempts.

### Missing metrics for ArgoCD installation

There is known issue with Argo CD and metrics collection. If you override `spec.source.helm.releaseName`, then Kube State and Node metrics are not collected due to the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There is known issue with Argo CD and metrics collection. If you override `spec.source.helm.releaseName`, then Kube State and Node metrics are not collected due to the following:
There is known issue with Argo CD and metrics collection. If you override `spec.source.helm.releaseName` in the `ApplicationSet`, which is used to configure your application in Argo CD, then Kube State and Node metrics are not collected due to the following:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkujawa-sumo Thanks for this suggestion. I applied it with some change, because there are both Application and ApplicationSet. I have been testing on Application and customer reported issue for ApplicationSet

vagrant/Makefile Outdated
Copy link
Contributor

@kasia-kujawa kasia-kujawa Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes! ❤️ It'll be easier to test installation with Argo CD 😍

@sumo-drosiek sumo-drosiek merged commit ee9e18b into main Jan 11, 2024
35 checks passed
@sumo-drosiek sumo-drosiek deleted the drosiek-argo branch January 11, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants