Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation): remove deprecated otelcol service #3571

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Feb 23, 2024

PR removes release_name-sumologic-otelcol service which was deprecated over year ago.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@mat-rumian mat-rumian requested a review from a team as a code owner February 23, 2024 11:09
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service will point to otelcolInstrumentation as deprecated and after 2023-01-15 should be removed.

😂

@mat-rumian mat-rumian enabled auto-merge (squash) February 23, 2024 11:15
@mat-rumian mat-rumian merged commit 89b5c2b into main Feb 23, 2024
45 checks passed
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this wait until v5? If there's no hurry, I'd rather make this kind of breaking change in a major release, even if it was deprecated for a long time.

@mat-rumian mat-rumian deleted the mat-rumian-remove-deprecated-otelcol-svc branch February 23, 2024 11:16
@mat-rumian
Copy link
Contributor Author

Can't this wait until v5? If there's no hurry, I'd rather make this kind of breaking change in a major release, even if it was deprecated for a long time.

Sorry just merged before your comment. I don't think it will be a pain for customers or us. It's over 1,5y since the service was deprecated. If you think that it will cause a lot of distractions I can revert and hold with this until v5 release.

@swiatekm
Copy link

I'd rather revert and wait until v5. In my experience, the fact that it was deprecated won't stop anyone from continuing to use it as long as it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants