-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation): remove deprecated otelcol service #3571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service will point to otelcolInstrumentation as deprecated and after 2023-01-15 should be removed.
😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this wait until v5? If there's no hurry, I'd rather make this kind of breaking change in a major release, even if it was deprecated for a long time.
Sorry just merged before your comment. I don't think it will be a pain for customers or us. It's over 1,5y since the service was deprecated. If you think that it will cause a lot of distractions I can revert and hold with this until v5 release. |
I'd rather revert and wait until v5. In my experience, the fact that it was deprecated won't stop anyone from continuing to use it as long as it works. |
)" This reverts commit 89b5c2b.
PR removes
release_name-sumologic-otelcol
service which was deprecated over year ago.Checklist