Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for GKE 1.25 and AKS 1.25, 1.26 #3633

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

aboguszewski-sumo
Copy link
Contributor

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@aboguszewski-sumo aboguszewski-sumo requested a review from a team as a code owner April 3, 2024 07:15
@@ -94,8 +94,8 @@ The following table displays the tested Kubernetes and Helm versions.
| K8s with EKS | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with EKS (fargate) | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with Kops | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with GKE | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with AKS | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we drop aks 1.26? I see e2e tests passing for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should drop it first probably? Docs say that it's no longer supported: https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-kubernetes-release-calendar

@@ -94,8 +94,8 @@ The following table displays the tested Kubernetes and Helm versions.
| K8s with EKS | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with EKS (fargate) | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with Kops | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
| K8s with GKE | 1.25<br/>1.26<br/>1.27<br/>1.28<br/>1.29 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we drop gke 1.25? I see e2e tests passing for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's proceed 🔥

@aboguszewski-sumo aboguszewski-sumo merged commit b993db3 into main Apr 3, 2024
17 checks passed
@aboguszewski-sumo aboguszewski-sumo deleted the aboguszewski-drop-gke-125 branch April 3, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants