-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pvc-cleaner): Clean Pods in Pending state due to zone mismatch with their PVC #3639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Rosiek <[email protected]>
4 tasks
sumo-drosiek
changed the title
Clean Pods in Pending state due to zone mismatch with their PVC
feat(pvc-cleaner) Clean Pods in Pending state due to zone mismatch with their PVC
Apr 5, 2024
sumo-drosiek
changed the title
feat(pvc-cleaner) Clean Pods in Pending state due to zone mismatch with their PVC
feat(pvc-cleaner): Clean Pods in Pending state due to zone mismatch with their PVC
Apr 5, 2024
sumo-drosiek
commented
Apr 5, 2024
@@ -2397,6 +2402,7 @@ pvcCleaner: | |||
|
|||
## Schedule for cronJobs | |||
schedule: "*/15 * * * *" | |||
scheduleForPendingPod: "*/5 * * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
scheduleForPendingPod: "*/5 * * * *" | |
scheduleForPendingPods: "*/5 * * * *" |
sumo-drosiek
commented
Apr 5, 2024
|
||
function print_help() { | ||
echo "This script removes the PVCs which cannot be bound due to Zone mismatch." | ||
echo " pvc-cleaner namespace POD-selector" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
echo " pvc-cleaner namespace POD-selector" | |
echo " pvc-cleaner-pending namespace POD-selector" |
sumo-drosiek
commented
Apr 5, 2024
app: {{ template "sumologic.labels.app.pvcCleaner.pendingPods" . }} | ||
{{- include "sumologic.labels.common" . | nindent 4 }} | ||
spec: | ||
schedule: {{ .Values.pvcCleaner.job.scheduleForPendingPod | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
schedule: {{ .Values.pvcCleaner.job.scheduleForPendingPod | quote }} | |
schedule: {{ .Values.pvcCleaner.job.scheduleForPendingPods | quote }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist