Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pvc-cleaner): Clean Pods in Pending state due to zone mismatch with their PVC #3639

Closed
wants to merge 1 commit into from

Conversation

sumo-drosiek
Copy link
Contributor

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek mentioned this pull request Apr 5, 2024
4 tasks
@sumo-drosiek sumo-drosiek changed the title Clean Pods in Pending state due to zone mismatch with their PVC feat(pvc-cleaner) Clean Pods in Pending state due to zone mismatch with their PVC Apr 5, 2024
@sumo-drosiek sumo-drosiek changed the title feat(pvc-cleaner) Clean Pods in Pending state due to zone mismatch with their PVC feat(pvc-cleaner): Clean Pods in Pending state due to zone mismatch with their PVC Apr 5, 2024
@@ -2397,6 +2402,7 @@ pvcCleaner:

## Schedule for cronJobs
schedule: "*/15 * * * *"
scheduleForPendingPod: "*/5 * * * *"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scheduleForPendingPod: "*/5 * * * *"
scheduleForPendingPods: "*/5 * * * *"


function print_help() {
echo "This script removes the PVCs which cannot be bound due to Zone mismatch."
echo " pvc-cleaner namespace POD-selector"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo " pvc-cleaner namespace POD-selector"
echo " pvc-cleaner-pending namespace POD-selector"

app: {{ template "sumologic.labels.app.pvcCleaner.pendingPods" . }}
{{- include "sumologic.labels.common" . | nindent 4 }}
spec:
schedule: {{ .Values.pvcCleaner.job.scheduleForPendingPod | quote }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schedule: {{ .Values.pvcCleaner.job.scheduleForPendingPod | quote }}
schedule: {{ .Values.pvcCleaner.job.scheduleForPendingPods | quote }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant