-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add instrumentation tests #3643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me, thanks for doing it!
One thing I'm wondering is if we shouldn't have self-contained tests per-instrumentation. Right now, you have one feature per instrumented application, and then a single feature that triggers all of them via curl and then checks if the data arrived. It would be more composable if each per-app feature also included the curl trigger and the check. Then it'd be possible to run them individually, and easier to keep track of what data we expect the instrumentation to output.
But that can be done in a followup, if need be. I'll leave it up to you, I'm fine merging this PR as is.
PR adds tests for instrumentation applied by OpenTelemetry-Operator.
Checklist