Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add instrumentation tests #3643

Merged
merged 13 commits into from
Apr 17, 2024
Merged

chore: add instrumentation tests #3643

merged 13 commits into from
Apr 17, 2024

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Apr 11, 2024

PR adds tests for instrumentation applied by OpenTelemetry-Operator.

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@mat-rumian mat-rumian marked this pull request as ready for review April 15, 2024 09:56
@mat-rumian mat-rumian requested a review from a team as a code owner April 15, 2024 09:56
@mat-rumian mat-rumian requested a review from swiatekm April 16, 2024 14:46
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me, thanks for doing it!

One thing I'm wondering is if we shouldn't have self-contained tests per-instrumentation. Right now, you have one feature per instrumented application, and then a single feature that triggers all of them via curl and then checks if the data arrived. It would be more composable if each per-app feature also included the curl trigger and the check. Then it'd be possible to run them individually, and easier to keep track of what data we expect the instrumentation to output.

But that can be done in a followup, if need be. I'll leave it up to you, I'm fine merging this PR as is.

@mat-rumian mat-rumian merged commit b20ae40 into main Apr 17, 2024
50 checks passed
@mat-rumian mat-rumian deleted the mat-rumian-add-instr-tests branch April 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants