Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ttlSecondsAfterFinished to setup and cleanup jobs #3656

Merged
merged 3 commits into from
Apr 17, 2024
Merged

feat: add ttlSecondsAfterFinished to setup and cleanup jobs #3656

merged 3 commits into from
Apr 17, 2024

Conversation

sumo-drosiek
Copy link
Contributor

Add ttlSecondsAfterFinished to setup and cleanup jobs to ensure that the job is removed after installation or cleanup

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner April 17, 2024 10:20
chore: changelog
886a9b8 
Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek linked an issue Apr 17, 2024 that may be closed by this pull request
Non-helm installation is not idempotent #1393
Closed
sumo-drosiek
sumo-drosiek commented Apr 17, 2024
View reviewed changes
deploy/helm/sumologic/README.md Outdated Show resolved Hide resolved
deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved
tests/helm/testdata/goldenfile/cleanup/basic.output.yaml Outdated Show resolved Hide resolved
tests/helm/testdata/goldenfile/cleanup/sumologic-mock-no-secret.output.yaml Outdated Show resolved Hide resolved
tests/helm/testdata/goldenfile/cleanup/sumologic-mock.output.yaml Outdated Show resolved Hide resolved
tests/helm/testdata/goldenfile/setup/basic.output.yaml Outdated Show resolved Hide resolved
tests/helm/testdata/goldenfile/setup/sumologic-mock-no-secret.output.yaml Outdated Show resolved Hide resolved
tests/helm/testdata/goldenfile/setup/sumologic-mock.output.yaml Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek enabled auto-merge (squash) April 17, 2024 12:36
@sumo-drosiek sumo-drosiek merged commit 15d6d7d into main Apr 17, 2024
44 checks passed
@sumo-drosiek sumo-drosiek deleted the drosiek-ttl branch April 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-helm installation is not idempotent
2 participants
@sumo-drosiek @swiatekm