Skip to content

Commit

Permalink
Require yq in Makefile, install yq on Windows CI runners (#1720)
Browse files Browse the repository at this point in the history
* chore: require yq in Makefile

Signed-off-by: Justin Kolberg <[email protected]>

* chore(ci): install yq on windows

Signed-off-by: Justin Kolberg <[email protected]>

* chore(ci): install yq on windows workflow-test

Signed-off-by: Justin Kolberg <[email protected]>

---------

Signed-off-by: Justin Kolberg <[email protected]>
Co-authored-by: Raj Nishtala <[email protected]>
  • Loading branch information
amdprophet and rnishtala-sumo authored Dec 19, 2024
1 parent b495cd8 commit 5e81667
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/workflow-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ jobs:
restore-keys: |
${{ steps.get-cache-key.outputs.restore-keys }}
- name: Install yq (Windows)
if: contains(inputs.arch_os, 'windows')
run: choco install yq

- name: Set default BUILDER_BIN_PATH
run: echo "BUILDER_BIN_PATH=${HOME}/bin" >> $GITHUB_ENV

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/workflow-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ jobs:
restore-keys: |
${{ steps.get-cache-key.outputs.restore-keys }}
- name: Install yq (Windows)
if: contains(inputs.arch_os, 'windows')
run: choco install yq

- name: Set default BUILDER_BIN_PATH
run: echo "BUILDER_BIN_PATH=${HOME}/bin" >> $GITHUB_ENV

Expand Down
5 changes: 5 additions & 0 deletions otelcolbuilder/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ BUILDER_BIN_PATH ?= $(HOME)/bin

INSTALLED_BUILDER_VERSION := $(shell $(BUILDER_BIN_NAME) version 2>&1)

INSTALLED_YQ_VERSION := $(shell yq --version 2>&1)
ifeq ($(INSTALLED_YQ_VERSION),)
$(error "The yq command is required but was not found")
endif

# Settings for macOS builds
ifeq ($(OS),darwin)
AC_USERNAME ?= [email protected]
Expand Down

0 comments on commit 5e81667

Please sign in to comment.