Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow other users to read config files #1408

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Don't allow other users to read config files #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b3808
Don't allow other users to read config files
echlebek Jan 5, 2024
bab1ccb
Merge branch 'main' into security/file-perms
echlebek Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/1408.fixed.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
sec: don't allow other users to read configuration files
3 changes: 2 additions & 1 deletion pkg/extension/opampextension/opamp_agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,8 @@ func (o *opampAgent) saveEffectiveConfig(dir string) error {
for k, v := range o.effectiveConfig {
p := filepath.Join(dir, k)

f, err := os.Create(p)
// OpenFile the same way os.Create does it, but with 0600 perms
f, err := os.OpenFile(p, os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0600)
if err != nil {
return err
}
Expand Down