feat(sumologicexporter)!: remove deprecated json_logs #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
commented
Feb 16, 2024
| } else { | ||
| body.CopyTo(recordCopy.Attributes().PutEmpty(s.jsonLogsConfig.LogKey)) | ||
| } | ||
| body.CopyTo(recordCopy.Attributes().PutEmpty(DefaultLogKey)) |
There was a problem hiding this comment.
We need to handle somehow non-empty body. I fallbacked to default behaviour
swiatekm
approved these changes
Feb 16, 2024
sumo-drosiek
force-pushed
the
drosiek-remove-json-logs
branch
from
eb6cbed to
2314020
Compare
andrzej-stencel
approved these changes
Feb 16, 2024
added 4 commits
February 16, 2024 12:23
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-remove-json-logs
branch
from
2314020 to
19382fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378
I removed
json_logslogs, but in order to handle non-empty body, I'm writing it tologkey, which was the default before the deprecation and removal