Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation for the attributes processor #1721

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: Add validation for the attributes processor #1721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4069d01
feat: Add validation for the attributes processor
rnishtala-sumo Dec 19, 2024
e6aea1d
Add test to validate the attributes processor
rnishtala-sumo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/1721.added.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
feat: Add validation for the attributes processor
2 changes: 2 additions & 0 deletions pkg/extension/opampextension/components.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension"
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage"
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/sumologicextension"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor"
Expand Down Expand Up @@ -88,6 +89,7 @@ func Components() (
errs = multierr.Append(errs, err)

processors, err := processor.MakeFactoryMap(
attributesprocessor.NewFactory(),
batchprocessor.NewFactory(),
memorylimiterprocessor.NewFactory(),
resourcedetectionprocessor.NewFactory(),
Expand Down
1 change: 1 addition & 0 deletions pkg/extension/opampextension/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/extension/pprofextension v0.114.0
github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage v0.114.0
github.com/open-telemetry/opentelemetry-collector-contrib/extension/sumologicextension v0.114.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.114.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.114.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.114.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.114.0
Expand Down
2 changes: 2 additions & 0 deletions pkg/extension/opampextension/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,8 @@ github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/zipkin
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/zipkin v0.114.0/go.mod h1:t5uoTcckI8kQeW1sZl8A+1UebVJPe47Qi3WQeNZu6w4=
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.114.0 h1:1xAInvRymxpsuIWz/plGH98eWRhmLVgUHqleBCEeoJM=
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.114.0/go.mod h1:3PSKkD/USW8EXij1UTwoRwDFIl0D0V5td9U3n0YEKTo=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.114.0 h1:fltPkjMuiVTtIVwoWUzbL0ad2CTCJsWfnCSDJQ9hSxU=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.114.0/go.mod h1:HcG364Is9u2EDqOUtQX0RwnbHtQqSh5+x2FdcYC+F1M=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.114.0 h1:QBR07Gaw6ePkufQ/AhHgBv4OlwzXlULTdiUnaKIlvLk=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.114.0/go.mod h1:coY0CV/sNj1hltRXKZr2gnrLvr7xUbnW+GhpCQpGR/Y=
github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.114.0 h1:ttRj/3GIpg+vUTeBI+EBeeWdNuvBT3S/ayoqpvA9B9s=
Expand Down
1 change: 1 addition & 0 deletions pkg/extension/opampextension/opamp_agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func TestApplyRemoteConfig(t *testing.T) {
{"ApplyKafkaMetricsConfig", "testdata/opamp.d/opamp-kafkametrics-config.yaml", false, ""},
{"ApplyElasticsearchConfig", "testdata/opamp.d/opamp-elastic-config.yaml", false, ""},
{"ApplyMysqlConfig", "testdata/opamp.d/opamp-mysql-config.yaml", false, ""},
{"ApplyattributesprocessorConfig", "testdata/opamp.d/opamp-attributes-processor.yaml", false, ""},
{"ApplyPostgresqlConfig", "testdata/opamp.d/opamp-postgresql-config.yaml", false, ""},
{"ApplyRabbitmqConfig", "testdata/opamp.d/opamp-rabbitmq-config.yaml", false, ""},
{"ApplyRedisConfig", "testdata/opamp.d/opamp-redis-config.yaml", false, ""},
Expand Down
45 changes: 45 additions & 0 deletions pkg/extension/opampextension/testdata/opamp.d/opamp-attributes-processor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
receivers:
mysql:
endpoint: localhost:3306
username: otel
password: test
database: otel
collection_interval: 10s
initial_delay: 1s
statement_events:
digest_text_limit: 120
time_limit: 24h
limit: 250
exporters:
sumologic:
processors:
attributes/example:
actions:
- key: db.table
action: delete
- key: redacted_span
value: true
action: upsert
- key: copy_key
from_attribute: key_original
action: update
- key: account_id
value: 2245
action: insert
- key: account_password
action: delete
- key: account_email
action: hash
- key: http.status_code
action: convert
converted_type: int

service:
pipelines:
metrics/mysql/09c98ea4-6686-4ab9-b3cd-f04070906441:
processors:
- attributes/example
receivers:
- mysql
exporters:
- sumologic
Loading