Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change required go version and update dependencies #281

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

kasia-kujawa
Copy link
Contributor

@kasia-kujawa kasia-kujawa commented Feb 16, 2022

  • change required go version and update dependencies
    • update github.com/go-logr/logr from v0.4.0 to v1.2.2
    • update k8s.io/api from v0.20.2 to v0.20.2
    • update k8s.io/apimachinery from v0.22.4 to v0.23.3
    • update k8s.io/client-go from v0.20.2 to v0.23.3
    • update sigs.k8s.io/controller-runtime from v0.8.3 to v0.11.1

Used the solution described in google/gnostic#262 (comment) to update dependencies.

Without changing required go version I wasn't able to update dependencies, simple replace does not work
Following error was appearing:

$ go get -u sigs.k8s.io/controller-runtime
go get: github.com/googleapis/[email protected]: parsing go.mod:
        module declares its path as: github.com/google/gnostic
                but was required as: github.com/googleapis/gnostic
  • fix: replace deprecated go get with go install
  • chore: set go version to 1.17 in github actions

related to #170

@kasia-kujawa kasia-kujawa force-pushed the kk-update-deps branch 4 times, most recently from 284322a to 6eeb76f Compare February 16, 2022 16:23
- update github.com/go-logr/logr from v0.4.0 to v1.2.2
- update k8s.io/api from v0.20.2 to v0.20.2
- update k8s.io/apimachinery from v0.22.4 to v0.23.3
- update k8s.io/client-go from v0.20.2 to v0.23.3
- update sigs.k8s.io/controller-runtime from v0.8.3 to v0.11.1
@kasia-kujawa kasia-kujawa marked this pull request as ready for review February 18, 2022 15:07
@kasia-kujawa kasia-kujawa requested a review from a team as a code owner February 18, 2022 15:07
@kasia-kujawa kasia-kujawa merged commit 4fb5c9e into main Feb 18, 2022
@kasia-kujawa kasia-kujawa deleted the kk-update-deps branch February 18, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants