Chore/release51 compatibility #61
Conversation
…blueprint integration
| actions: [ | ||
| { | ||
| actions: { | ||
| [PlayoutActions.adlib]: { |
There was a problem hiding this comment.
I think this will technically work, but may be confusing to the reader? I think this should preferably be some sort of a stable ID.
There was a problem hiding this comment.
I agree with Jan's comment, it's a bit of an indirection. I would favor having an enum with the various action id's but even just a hardcoded string here would be more understandable to me.
| { | ||
| }, | ||
| triggers: { | ||
| [TriggerType.hotkey]: { |
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "extends": "./tsconfig.build.json", | |||
There was a problem hiding this comment.
Should this just reference ./packages/blueprints/tsconfig.build.json? The actual ./tsconfig.build.json seems to be incorrect anyway, since it has baseUrl as ./?
| default: { | ||
| name: 'Default', | ||
| config: { | ||
| dvePresets: {}, |
There was a problem hiding this comment.
I think a default 2box layout could be added here.
| actions: [ | ||
| { | ||
| actions: { | ||
| [PlayoutActions.adlib]: { |
There was a problem hiding this comment.
I agree with Jan's comment, it's a bit of an indirection. I would favor having an enum with the various action id's but even just a hardcoded string here would be more understandable to me.
| studioConfigManifest, | ||
| studioMigrations, | ||
| studioConfigSchema: JSONBlobStringify(ConfigSchema), | ||
| configPresets: { |
There was a problem hiding this comment.
I think these config presets & playoutDevice configs could have better defaults to make it easier for new users to demo Sofie
This PR is made on behalf of Superfly.
Current behavior:
The current version of Demo-blueprints did not work on Release51
Changes:
This PR is updated to support current development state of Release 51