Skip to content

Commit

Permalink
SRM-2513 update logo & documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
goldenraphti committed Oct 31, 2024
1 parent 0599973 commit 87417e0
Show file tree
Hide file tree
Showing 12 changed files with 2,715 additions and 2,656 deletions.
19 changes: 12 additions & 7 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,20 @@

## \[10.12.2\] - 14.08.2024

## Component changes
## Identity

- Typography
- Colors

- change font family of "title 6"/h6 from Arial to the brand's headline font (e.g. "SwedbankPay Headline Bold" or "Futura PT W08 Demi" depending on brand)
- updated primary color from current value `#FDC129` to actual Brand guideline's `#FDC92A`

- Progress-steps
- Logotypes
- updated logotype to the new fixed version
- update Documentation

- fix UI of the horizontal yellow line when the 1st and last steps are in state “ongoing selected”
## Component changes

- Dropdown
- fix script for initating for a specific `id` (`init(id)`)
- Expandable PayEx (contribution from Simon Wahlstrom 💫)
- font family change for PayEx expandables
- Button PayEx (contribution from Johanna Prinz 💫)
- font family change
- colors updated
46 changes: 23 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@babel/eslint-parser": "^7.24.1",
"@babel/preset-env": "^7.24.4",
"@babel/preset-react": "^7.24.1",
"@playwright/test": "^1.45.3",
"@playwright/test": "^1.48.1",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^14.2.2",
"@testing-library/user-event": "^14.5.2",
Expand Down
53 changes: 52 additions & 1 deletion src/App/Identity/identity/Logotype/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import React from "react";

import { ComponentPreview, DocContainer } from "@docutils";
import {
ComponentPreview,
DocContainer,
EditableComponentPreview,
} from "@docutils";
import CodeTags from "@components/CodeTags";
import LogotypeComponent from "@components/Logotype";
import { logoBlack, logoWhite, logoPayex, logotypeMisuses } from "./constants";
Expand Down Expand Up @@ -435,6 +439,51 @@ const Overview = () => (
</section>
);

const ImgSrcExamples = ({ isNPM }) => {
let imgSrc;

if (isNPM) {
imgSrc = `@swedbankpay/design-guide/src/img/${brand}/logo/${brand}-logo-h.svg`;
} else {
imgSrc = `https://design.${brand}.com/v/10.12.2/img/logo/${brand}-logo-h.svg`;
}

return (
<img
src={imgSrc}
alt={`${brand} horizontal logo`}
className="logotype-horizontal logotype-lg"
/>
);
};

const LogoSrc = () => (
<section>
<h2 id="logotype-pathname">Logo src pathname</h2>
<h3>Recommended way - load from the NPM package</h3>
<p>
Use the logo assets shipped with the npm package. This way it always stay
current and can be used at built time.
</p>
<EditableComponentPreview language="html" codeFigure={true}>
<ImgSrcExamples isNPM={true} />
</EditableComponentPreview>
<h3>Option #2 - Use the image from the website (the CDNish way)</h3>
<p>
Honestly, it's not recommended. For 2 reasons: it's slow (unless used at
build time in a SSG way, but most of the time it will be implemented in a
way that it gets called on client side) and on top of that it will become
potentially obsolete the second you wrote it since the image src path
leads to a hardcoded version of the design-guide. Therefore, if (when) we
will we change the logo in the future in the design system your version
will not get updated automatically.
</p>
<EditableComponentPreview language="html" codeFigure={true}>
<ImgSrcExamples isNPM={false} />
</EditableComponentPreview>
</section>
);

const Logotype = () => (
<>
{brand === "swedbankpay" && (
Expand All @@ -450,6 +499,7 @@ const Logotype = () => (
<Overview />
<LogoBlack />
<LogoWhite />
<LogoSrc />
<SpacingZone />
<MisuseLogo />
<LogotypeBackgrounds />
Expand All @@ -460,6 +510,7 @@ const Logotype = () => (
{brand === "payex" && (
<DocContainer>
<LogoPayex />
<LogoSrc />
<Favicon />
</DocContainer>
)}
Expand Down
Binary file modified src/img/swedbankpay/logo/swedbankpay-logo-h-neg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 87417e0

Please sign in to comment.