Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions expanded #347

Closed
wants to merge 40 commits into from
Closed

Conversation

VikingTristan
Copy link
Contributor

@VikingTristan VikingTristan commented Jul 17, 2020

Replace AppVeyor and GitHub Pages with GitHub Actions and Azure

This pull request introduces release branches as part of a new workflow.

  • Pull request workflow
  • Release workflow
    • Creates a release body with the content of a RELEASE_NOTES.md file. We will then be able to retain the changelog of all versions in a file and eventually fix this issue
  • Develop and feature branch workflows
  • Make tests run on GitHub Actions agents
    • Three test files has been ignored as they caused headaches
  • Documentation updated
  • Deploy all previous versions of the Design Guides to azure
  • A janitor workflow
    • This workflow is executed when a branch is merged into develop
    • Cleans up feature folders within azure containers
    • Automatically deletes feature branches merged to develop
  • Remove dependencies on root files.
    • E.g. favicon currently points to design.swedbankpay.com/icons/favicon.png when it should really be pointing at design.swedbankpay.com/v/x.x.x/icons/favicon.png. Current solution won't work when moving to azure as nothing but redirector files will be on root.
      • To support older versions of Design Guide, certain logos and images has been deployed to root.
  • Automatically update changelog in release branches
  • Automatically create pull request to master and develop when creating release branch
    • Add content of release notes to PR body

@VikingTristan VikingTristan requested a review from asbjornu July 17, 2020 12:55
@VikingTristan VikingTristan self-assigned this Jul 17, 2020
@github-actions
Copy link

github-actions bot commented Jul 17, 2020

Size Change: +2 B (0%)

Total Size: 333 kB

Filename Size Change
dist/PullRequest/scripts/app.js 161 kB +2 B (0%)
dist/PullRequest/scripts/dg-dashboard.js 65.6 kB +1 B (0%)
dist/PullRequest/scripts/dg.js 53.9 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/PullRequest/scripts/dg-style.js 150 B 0 B
dist/PullRequest/styles/app.css 670 B 0 B
dist/PullRequest/styles/dg-style.css 51.9 kB 0 B

compressed-size-action

Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at all that deleted code! Marvellous! 👏

.github/scripts/variables.sh Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits that will make Codacy a tiny bit happier.

.github/scripts/find-merge-source-branch.sh Outdated Show resolved Hide resolved
.github/scripts/find-merge-source-branch.sh Outdated Show resolved Hide resolved
.github/scripts/find-merge-source-branch.sh Outdated Show resolved Hide resolved
.github/scripts/find-merge-source-branch.sh Outdated Show resolved Hide resolved
@VikingTristan VikingTristan marked this pull request as ready for review August 24, 2020 11:25
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #347 (d8e5083) into develop (eda9284) will decrease coverage by 19.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #347       +/-   ##
============================================
- Coverage    83.76%   64.72%   -19.05%     
============================================
  Files          184      194       +10     
  Lines         2982     3640      +658     
============================================
- Hits          2498     2356      -142     
- Misses         484     1284      +800     
Impacted Files Coverage Δ
src/scripts/main/datepicker/formats.js 0.00% <0.00%> (-100.00%) ⬇️
src/scripts/main/topbar/NavMenu.js 2.94% <0.00%> (-83.83%) ⬇️
src/scripts/main/datepicker/index.js 24.00% <0.00%> (-76.00%) ⬇️
src/scripts/main/topbar/index.js 24.44% <0.00%> (-62.23%) ⬇️
src/App/docutils/JavascriptDocs/index.js 42.85% <0.00%> (-42.86%) ⬇️
src/scripts/main/topbar/index.test.js 0.00% <0.00%> (ø)
src/scripts/main/datepicker/formats.test.js 0.00% <0.00%> (ø)
src/scripts/main/datepicker/index.test.js 0.00% <0.00%> (ø)
...mponentsDocumentation/components/Lightbox/index.js 0.00% <0.00%> (ø)
src/App/docutils/JavascriptDocs/index.test.js 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda9284...d8e5083. Read the comment docs.

@VikingTristan VikingTristan force-pushed the feature/github-actions-expanded branch from 83f0415 to 1694893 Compare October 16, 2020 08:55
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 42
           

Complexity increasing per file
==============================
- jest.setup.js  6
         

Complexity decreasing per file
==============================
+ webpack.config.js  -2
         

Clones added
============
- jest.setup.js  1
         

See the complete overview on Codacy

asbjornu
asbjornu previously approved these changes Oct 16, 2020
Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some stellar shit

pthoang
pthoang previously approved these changes Nov 25, 2020
Copy link
Contributor

@pthoang pthoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VikingTristan VikingTristan force-pushed the feature/github-actions-expanded branch from 9234d3f to d8e5083 Compare March 4, 2021 15:10
@VikingTristan
Copy link
Contributor Author

VikingTristan commented Apr 13, 2021

This entire Pull Request is being split up into several small ones.

#446

#455

#457

#458

#459

#461

#591

More to come...

@eskilsen eskilsen closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog question
5 participants