-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions expanded #347
Conversation
Size Change: +2 B (0%) Total Size: 333 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at all that deleted code! Marvellous! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits that will make Codacy a tiny bit happier.
Codecov Report
@@ Coverage Diff @@
## develop #347 +/- ##
============================================
- Coverage 83.76% 64.72% -19.05%
============================================
Files 184 194 +10
Lines 2982 3640 +658
============================================
- Hits 2498 2356 -142
- Misses 484 1284 +800
Continue to review full report at Codecov.
|
83f0415
to
1694893
Compare
Here is an overview of what got changed by this pull request: Issues
======
+ Solved 42
Complexity increasing per file
==============================
- jest.setup.js 6
Complexity decreasing per file
==============================
+ webpack.config.js -2
Clones added
============
- jest.setup.js 1
See the complete overview on Codacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some stellar shit
1694893
to
1a2bff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1a2bff1
to
0a6fce1
Compare
0a6fce1
to
c3d991f
Compare
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Also delete feature branch when merged
This prevents favicon and other icons and logos to point to root domain. Instead, it now points to its respective version.
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Destructured into multiple jobs to create two PRs simultaneously
9234d3f
to
d8e5083
Compare
Replace AppVeyor and GitHub Pages with GitHub Actions and Azure
This pull request introduces release branches as part of a new workflow.
RELEASE_NOTES.md
file. We will then be able to retain the changelog of all versions in a file and eventually fix this issuedesign.swedbankpay.com/icons/favicon.png
when it should really be pointing atdesign.swedbankpay.com/v/x.x.x/icons/favicon.png
. Current solution won't work when moving to azure as nothing but redirector files will be on root.