Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new variable script from Pull Request 347 #394

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

VikingTristan
Copy link
Contributor

Introduce new variable script from #347

Description

This will make our Github Actions run again by using a more safe approach to variables. By using parts of the incoming #347 pull request, develop branch won't deviate from incoming code and merging will be easier.

Motivation and Context

Github actions won't run using deprecated commands.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VikingTristan VikingTristan self-assigned this Nov 30, 2020
@github-actions
Copy link

github-actions bot commented Nov 30, 2020

Size Change: 0 B

Total Size: 331 kB

ℹ️ View Unchanged
Filename Size Change
dist/PullRequest/scripts/app.js 161 kB 0 B
dist/PullRequest/scripts/dg-dashboard.js 65.6 kB 0 B
dist/PullRequest/scripts/dg-style.js 150 B 0 B
dist/PullRequest/scripts/dg.js 53.3 kB 0 B
dist/PullRequest/styles/app.css 670 B 0 B
dist/PullRequest/styles/dg-style.css 50 kB 0 B

compressed-size-action

Copy link
Contributor

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@VikingTristan VikingTristan merged commit b6287b7 into develop Nov 30, 2020
@VikingTristan VikingTristan deleted the fix/gh-actions-variables branch November 30, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants