Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pfe 107 update cards dg #1030

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

PriJoh
Copy link
Collaborator

@PriJoh PriJoh commented Dec 20, 2024

Description

I have made the following updates to the cards:

  • Updated the styling according to the Figma design for the default, hover, and select states.

  • Added the Do's and Don'ts images for both portrait and landscape orientations.

What remains to be done is to implement the new image that should appear when selecting a card with an image. The image has been added to the branch, and a file named constantspayex.js has been created, where the logic should reside. The connection itself still needs to be implemented.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image
image
image
image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

github-actions bot commented Dec 20, 2024

Size Change: +44 B (0%)

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 73.2 kB 0 B
dist/designguide/scripts/dg.js 24.9 kB 0 B
dist/designguide/styles/documentation-payex.css 10.2 kB 0 B
dist/designguide/styles/documentation-swedbankpay.css 9.27 kB 0 B
dist/designguide/styles/payex.css 53.6 kB +22 B (+0.04%)
dist/designguide/styles/swedbankpay.css 50.9 kB 0 B
dist/scripts/3563.js 72.1 kB 0 B
dist/scripts/dg-dashboard.js 73.2 kB 0 B
dist/scripts/dg.js 24.9 kB 0 B
dist/scripts/payex.js 326 kB 0 B
dist/scripts/swedbankpay.js 326 kB 0 B
dist/styles/documentation-payex.css 10.2 kB 0 B
dist/styles/documentation-swedbankpay.css 9.27 kB 0 B
dist/styles/payex.css 53.6 kB +22 B (+0.04%)
dist/styles/swedbankpay.css 50.9 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants